site/smitten-kitchen#1986
Open
swise5 wants to merge 3 commits into
Open
Conversation
Implements support for both site formats: - Modern format (2020+): h-recipe microformat with schema.org - Old format (pre-2020): Plain HTML with italic instruction headers Includes test data for both formats: - smittenkitchen_1: Modern format (banana chocolate chip cake) - smittenkitchen_2: Old format (baked chickpeas with pita chips)
- Fix modern format: instructions weren't being extracted because code was calling non-existent self.schema.instructions_list() - Fix old format: content bounds detection to avoid sidebar content - Add _get_old_format_recipe_bounds() helper for consistent extraction - Handle yields with ranges like '20 to 24 servings' - Update title extraction to use h1.entry-title for both formats WIP: Need to verify only 2 formats exist and test across more years
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies if I've gone about this in a boneheaded way - I've tried to fork @lukemcguire's fork and then merge it with the upstream repo, but please reject if there's a more elegant way to do this!