Fix dagelijksekost title: prefer og:title over schema.org name#2000
Open
Naliath wants to merge 1 commit into
Open
Fix dagelijksekost title: prefer og:title over schema.org name#2000Naliath wants to merge 1 commit into
Naliath wants to merge 1 commit into
Conversation
On some dagelijksekost.vrt.be pages the schema.org Recipe name is an SEO teaser sentence (e.g. "Jeroen Meus maakt een cremeux van citroen op een bodem van witte chocolade en gepofte rijst, met rode bessen.") while the og:title meta tag carries the clean dish name. Prefer og:title and fall back to the schema title when it is absent. Adds a second test fixture exercising a page with the teaser-style schema name; renames the existing fixture to the _1/_2 convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some dagelijksekost.vrt.be pages the schema.org Recipe
nameis an SEO teaser sentence rather than the dish name, while theog:titlemeta tag carries the clean title.Example — https://dagelijksekost.vrt.be/gerechten/cremeux-citroen-bodem-witte-chocolade-gepofte-rijst-rode-bessen:
name:Jeroen Meus maakt een crémeux van citroen op een bodem van witte chocolade en gepofte rijst, met rode bessen.og:title:Crémeux van citroen, bodem van witte chocolade, gepofte rijst en rode bessenThe existing test fixture (vol-au-vent) happens to have a clean schema name, so the suite never caught this. Other consumers work around it downstream (e.g. tomklaasen/dagelijksekost-paprika reads
og:titleitself instead of usingscraper.title()).Changes:
DagelijkseKost.title()now prefersog:titleand falls back to the schema title when the meta tag is absent._1/_2convention.Full test suite passes (1110 tests), black/flake8 clean.
🤖 Generated with Claude Code