fix(sqlquery):查询页面根据表名搜索实例功能优化 - #3233
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbeb459279
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| var dbType = $("#table-locator-db-type").val(); | ||
| if (!dbType) { | ||
| alert("请选择数据库类型"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
这里的数据库类型要改成可选, 这里设计的是你有需要可以替换实现, 比如我们企业内部是换成了 prometheus 作为数据源, 那个很快, 你们如果有关于表的元数据服务, 也可以自己实现
There was a problem hiding this comment.
公司目前的基建还没做到元数据管理这块，当前这种实现我觉得还挺好的
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c5ca6be3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
基本不存在需要通过遍历所有实例来搜索表名的情况
添加一个可以选择数据库类型的下拉框，搜索之前先选择数据库类型
如果未选择数据库类型，就填了表名，弹出alert
