HHH-18871 Nested NativeQuery Mappings #11062
Open
+108
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danish-ali
reviewed
Oct 11, 2025
There was a problem hiding this comment.
Nice fix for the duplicate segment issue.
The de-dup check uses path.getLocalName().equals(fetchableName), which may skip a valid next-level segment when names repeat across levels (e.g., children/children). Consider comparing the candidate full path vs. current path and skip only when equal, or otherwise scoping the guard to intra-step duplicates. A short comment explaining the rationale would help future readers.
robwgreenjr
force-pushed
the
HHH-18871
branch
from
a82f966 to
fc645d7
Compare
|
@danish-ali Thanks for the comment! There actually was no duplicate issue and my solution was not nice at all 😞. Your comment made me add another test to prove your suggestion wouldn't have helped though! Doing that made me realize my approach was completely wrong, so thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue caused by not setting
{element}in navigable path when dealing with collections, which didn't allow correct mapping toTableGroup.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18871