HHH-19857 When one of the lazy attributes is null the other ones may not get initialized correctly / HHH-19856 @LazyGroup is not always respected
#11110
Conversation
…y not get initialized correctly
to prevent it mutation within the init method
marko-bekhta
force-pushed
the
bug/HHH-19856-lazy-problems
branch
from
ec28dc2 to
27b0110
Compare
| final Set<String> initializedLazyAttributeNames = interceptor.getInitializedLazyAttributeNames(); | ||
| // Create a copy of init attrs, since lazySelectLoadPlan.load may update the set inside the interceptor, | ||
| // and we end up with the modified one here: | ||
| final Set<String> initializedLazyAttributeNames = new HashSet<>( interceptor.getInitializedLazyAttributeNames() ); |
There was a problem hiding this comment.
I think this might be only "hiding" the problem: we don't want this method to ignore the lazy attribute interceptor's initialized attributes set, as they might be read by other logic (e.g. field writes) instead of explicitly by this method.
I tried looking into this, and the lazySelectLoadPlan.load() call seems to be doing just that, so I believe a better fix would be adapting the for loop that iterates through the lazy-group attributes to account for that.
There was a problem hiding this comment.
👍🏻 if you'll be looking into this, let's push that set variable initialization waaaaaaaaaaaaaay down after the lazySelectLoadPlan.load. Because as the things are atm it's confusing at best, that the initializedLazyAttributeNames changes mid method 🙂
|
Thanks @marko-bekhta for looking into this one. As for the failing test, I believe that might be intended, I've tried explaining what I think is happening on the issue. |
2 participants
https://hibernate.atlassian.net/browse/HHH-19857
https://hibernate.atlassian.net/browse/HHH-19856
test cases for the issues ^ + a possible fix for a HHH-19857
Issues are caused by changes made for HHH-19805
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.