HHH-5247 - Support indexes and unique-keys in schema validator #11461
+549
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
approved these changes
Dec 18, 2025
| ExecutionOptions options, | ||
| Dialect dialect) { | ||
| var validationType = ConstraintValidationType.interpret( UNIQUE_KEY_VALIDATION, options.getConfigurationValues() ); | ||
|
|
Member
There was a problem hiding this comment.
Maybe move this check up?
Suggested change
| if ( validationType == ConstraintValidationType.NONE ) { | |
| return; | |
| } |
| ExecutionOptions options, | ||
| Dialect dialect) { | ||
| var validationType = ConstraintValidationType.interpret( INDEX_VALIDATION, options.getConfigurationValues() ); | ||
|
|
Member
There was a problem hiding this comment.
Maybe move this check up?
Suggested change
| if ( validationType == ConstraintValidationType.NONE ) { | |
| return; | |
| } |
| fail( "Not expecting an exception" ); | ||
| } | ||
| } | ||
| updateSchema( schema5, schemaTooling, registry ); |
Member
There was a problem hiding this comment.
This seems to fail on Oracle because it can't match the index with the generated name IDX6vwh1addgrj8v4h4od0bey3th for persons (name) against the person_name index on the same column. Just wanted to give you this hint as I looked into the failure report.
Member
Author
There was a problem hiding this comment.
I'm not following. You mean with the ALL param? In that case, we are expecting a failure for exactly that reason.
Member
Author
There was a problem hiding this comment.
Oh, you mean on the schema-update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-5247 - Support indexes and unique-keys in schema validator
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-5247