Skip to content

add no-strict feature to ignore InvalidDirectives #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philgebhardt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add no-strict feature to ignore InvalidDirectives #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6df5fa8
add no-strict feature to ignore InvalidDirectives
philgebhardt Nov 21, 2019
58673b4
Merge branch 'master' into pag/add-no-strict
May 16, 2021
a9c79ff
rustc 1.55 emitted a warning that patches and features are mutually e…
Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ hostname = { version = "^0.3", optional = true }

[features]
system = ["hostname"]
strict = []

[lib]
name = "resolv_conf"
Expand Down
6 changes: 6 additions & 0 deletions src/grammar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ quick_error!{
display("option at line {} is not recognized", line)
}
/// Error returned when a invalid directive is found.
#[cfg(feature="strict")]
InvalidDirective(line: usize) {
display("directive at line {} is not recognized", line)
}
Expand Down Expand Up @@ -224,7 +225,12 @@ pub(crate) fn parse(bytes: &[u8]) -> Result<Config, ParseError> {
}
}
}
#[cfg(feature="strict")]
_ => return Err(InvalidDirective(lineno)),

#[cfg(not(feature="strict"))]
_ => /* ignore invalid directives when no-strict */ (),

}
}
Ok(cfg)
Expand Down