Fixed swagger mismatches #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbolles
requested changes
Apr 1, 2025
| @@ -16,7 +16,7 @@ export class Message { | |||
| example: 'Hello, how can you help me today?' | |||
| }) | |||
| @IsString() | |||
| text: string; | |||
| content: string; | |||
There was a problem hiding this comment.
The field should be text not content
| @@ -24,27 +24,27 @@ import { CreateProxyMappingDto } from './dtos/create.dto'; | |||
| export class DeepchatProxyController { | |||
| constructor(private readonly deepchatProxyService: DeepchatProxyService) {} | |||
|
|
|||
| @Get('/:id') | |||
| @Get('/:model') | |||
There was a problem hiding this comment.
I'm not sure we want to move away from using the ID for handling the proxying
| return response; | ||
| } | ||
|
|
||
| async proxyRequestByModel(model: string, body: any): Promise<any> { |
There was a problem hiding this comment.
I think for now we want to keep the proxy request by ID
| toJSON: { | ||
| virtuals: true, | ||
| transform: (_, ret) => { | ||
| ret.id = ret._id; |
There was a problem hiding this comment.
We currently use _id through the code, so for now I wouldn't apply the transformation
| createdAt: Date; | ||
|
|
||
| @ApiProperty({ description: 'Last update timestamp', format: 'date-time' }) | ||
| @Prop({ default: Date.now }) |
Retested and made changes |
cbolles
force-pushed
the
main
branch
4 times, most recently
from
0c3565a to
96377d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: Ran though swaggerdocs and UI to fix name mismatches cause 500 errors