add Australian signals (NSW, part 1) #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hiddewie merged 2 commits into hiddewie:master from k-yle:kh/nsw-lx-1

Nov 14, 2025

k-yle commented Oct 31, 2025

This PR adds all light signals for New South Wales (Australia), except main and distant, because those two are more complicated, like the italian system.

See the osmwiki page for details.

In Australia, there can be up to 6 train_protection signals on a single pole (example), so we need to increase the limit from 5 to 6.

hiddewie reviewed

View reviewed changes

proxy/js/features.mjs

    
                      },

                    },

                    feature5: {

                      name: 'Senary signal',

Owner

hiddewie Nov 5, 2025

👍 :)

Owner

hiddewie commented Nov 5, 2025

Icons looks great, nice work.

hiddewie reviewed

View reviewed changes

features/signals_railway_signals.yaml Outdated Show resolved Hide resolved

hiddewie reviewed

View reviewed changes

features/signals_railway_signals.yaml Outdated Show resolved Hide resolved

hiddewie reviewed

View reviewed changes

features/signals_railway_signals.yaml Outdated Show resolved Hide resolved

hiddewie reviewed

View reviewed changes

features/signals_railway_signals.yaml Outdated Show resolved Hide resolved

Owner

hiddewie commented Nov 5, 2025

Do you want to process the TODOs in this pull request, or at a later time? Both options are fine for me!

Owner

hiddewie commented Nov 5, 2025

Tested a bit around Sydney

(http://localhost:8000/#view=19.77/-33.8389819/151.1985319&style=signals):

(http://localhost:8000/#view=19.63/-33.833115/151.1928916&style=signals):

(http://localhost:8000/#view=18.42/-33.820885/151.194292&style=signals):

(http://localhost:8000/#view=17.78/-33.698961/151.100139&style=signals):

Nice!

k-yle marked this pull request as draft

November 12, 2025 08:39


          add Australian signals (NSW, part 1)

bb3f170

k-yle force-pushed the kh/nsw-lx-1 branch from 46eb78a to bb3f170 Compare

November 13, 2025 09:53

k-yle marked this pull request as ready for review

November 13, 2025 09:55

Author

k-yle commented Nov 13, 2025

the TODO comments and other feedback should be all addressed now

hiddewie approved these changes

View reviewed changes


          Merge branch 'master' into kh/nsw-lx-1

5332ac8

hiddewie enabled auto-merge (squash)

November 14, 2025 19:59

Owner

hiddewie commented Nov 14, 2025

Great, thanks, let's merge!

hiddewie merged commit bb0331b into hiddewie:master

10 of 12 checks passed

hiddewie mentioned this pull request

Fix import tests for shunting_route tags #666

Merged

hiddewie added a commit that referenced this pull request


          Fix import tests for shunting_route tags (#666)

e1b4ab8

After #642 CI
failed in #642
because of missing merge checks for import tests.

k-yle deleted the kh/nsw-lx-1 branch

November 14, 2025 23:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet