Simplify IT main/combined/distant icons with composed icons #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to test-it-icons # Conflicts: # features/signals_railway_signals.yaml # proxy/js/styles.mjs # proxy/js/ui.js
hiddewie
changed the title
Followup on #657 Features with multiple icons did not output their icon height correctly for non-center-positioned icons. Now the feature icon height is calculated as ``` max(max(centered) + sum(top_bottom), left_right) ``` with centered the height of centered icons, `top_bottom` the height of the top/bottom positioned icons, and `left_right` the left/right positioned icons. Before After
This reverts commit 0000343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application of #657 for simplifying the IT icons.
Related to #639
cc @MatCr90 this PR simplifies the icon setup for the IT main/combined/distant signals.
(http://localhost:8000/#view=16.99/45.666447/11.936039&style=signals):
(http://localhost:8000/#view=16.62/45.541332/11.539128&style=signals):
(http://localhost:8000/#view=18.96/45.5404914/11.5740117&style=signals):
TODO: