fix(profile): align infinite traffic threshold with unlimited display check#2055
Open
Joursoir wants to merge 1 commit intohiddify:mainfrom
Open
fix(profile): align infinite traffic threshold with unlimited display check#2055Joursoir wants to merge 1 commit intohiddify:mainfrom
Joursoir wants to merge 1 commit intohiddify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subscription sends
total=0(meaning unlimited traffic), the parser maps it toinfiniteTrafficThreshold + 1(~857 GiB). But the UI only shows∞ GiBwhentotal > 10 TiB. Since 857 GiB < 10 TiB, the app incorrectly displays a finite quota andQuota exceededwarnings.infiniteTrafficThresholdvalue from 857 GiB to 10 TiB to match the display threshold10 * 1099511627776withProfileParser.infiniteTrafficThresholdfor a single source of truthFixes #1974