feat: Test suites improvements #1001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improvement on check for avaiable block at BlockAccessServicePlugin - Fail fast when receiving both `retrieve_latest` and `block_number` on getSingleBlock Request to avoid bad DevEx and confusion - since 0 is a valid block, we expect -1 when latest is set to true. - Fixed UTs - Added E2E Test Suite for Healthz and Metrics endpoints - Added E2E Test Suite for GetSingleBlockAPI scenarios Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
AlfredoG87
added
Tests
AlfredoG87
changed the base branch from
505-duplicate-and-behind-cases
to
505-plugins-services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
retrieve_latestandblock_numberon getSingleBlock Request to avoid bad DevEx and confusion