chore: Fix gradle baseline #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the script to use the distributions folder in `app` and to hash the `tar` instead of looking for `jar` files. Signed-off-by: Joseph Sinclair <[email protected]>
jsync-swirlds
requested review from
nathanklick,
jasperpotts,
Nana-EC and
AlfredoG87
and removed request for
nathanklick
AlfredoG87
approved these changes
Apr 16, 2025
jsync-swirlds
added a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Joseph Sinclair <[email protected]>
jsync-swirlds
added a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Joseph Sinclair <[email protected]>
jsync-swirlds
added a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Joseph Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Adjusted the path and file(s) to generate the manifest to be the
app/build/distributionsfolder andtarfiles instead ofserver/build/libsandjarfiles.With multiple modules and plugins, the
tarcontains all the modules and dependencies;libsonly contains theappmodulejar(andserverdoesn't exist, which is what caused the failure).