Skip to content

Conversation

@AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Sep 4, 2025

Reviewer Notes

  • migrate to use latest version of solo command structure
  • Latest versions of CN, BN and MN by defaults.
  • Removed hardcoded MN Image, Custom built by XIN as a temporary workaround.
  • Compacted the WF Steps by grouping them similar to CITR WF on CN Repo
  • Added TCK Regression Test (disabled by default) and limited to only 1 file test, same as CN Repo CITR.
  • Removed Obsolete Incomplete E2E Test attempt on Hedera Local Node.

Pending to decide the cadence of the run for this WF, right now only under demand

Recent pass with TCK Regression Suites enabled:
https://github.com/hiero-ledger/hiero-block-node/actions/runs/19021065941

Related Issue(s)

Fixes #1818

@AlfredoG87 AlfredoG87 self-assigned this Sep 4, 2025
@AlfredoG87 AlfredoG87 added this to the 0.18.0 milestone Sep 4, 2025
@AlfredoG87 AlfredoG87 added github_actions Pull requests that update Github Actions code. CI/CD Issues related to the CI/CD. labels Sep 4, 2025
@AlfredoG87 AlfredoG87 modified the milestones: 0.18.0, 0.19.0, 0.20.0 Sep 16, 2025
@AlfredoG87 AlfredoG87 force-pushed the solo-e2e-mn-importer-tag-upgrade branch from d9b7121 to 4c26b95 Compare October 3, 2025 03:14
@AlfredoG87 AlfredoG87 modified the milestones: 0.20.0, 0.21.0 Oct 8, 2025
@AlfredoG87 AlfredoG87 modified the milestones: 0.21.0, 0.22.0 Oct 23, 2025
@AlfredoG87 AlfredoG87 force-pushed the solo-e2e-mn-importer-tag-upgrade branch from e75ab57 to bb0cbf5 Compare November 1, 2025 04:33
@AlfredoG87 AlfredoG87 changed the title ci(solo-e2e): Update the MN tag to use latest ci(solo-e2e): Various Improvements to Solo E2E CI Test Nov 1, 2025
@AlfredoG87 AlfredoG87 force-pushed the solo-e2e-mn-importer-tag-upgrade branch from ffd690a to 6a5114e Compare November 1, 2025 05:20
@AlfredoG87 AlfredoG87 marked this pull request as ready for review November 3, 2025 01:30
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner November 3, 2025 01:30
@AlfredoG87 AlfredoG87 added the Tests issue related to enhancing the tests label Nov 3, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Using parameter published version of MN instead of custom image provided by Xin.

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
…s some work to make simpler.

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Printing troubleshooting info.
Do port forward in a single command for all necessary services for other possible uses, including TCK Client regression test suite.
Reduced the time of sleep just to produce more empty blocks
Added MN Validation for last block queried on previous step
Added TCK conditional steps for regression suite limited to
test-contract-execute-transaction.ts test
Added Stop step

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
@AlfredoG87 AlfredoG87 force-pushed the solo-e2e-mn-importer-tag-upgrade branch from 57fcd5d to be10ea2 Compare November 3, 2025 19:59
@AlfredoG87 AlfredoG87 modified the milestones: 0.22.0, 0.23.0 Nov 5, 2025
Copy link
Contributor

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one item to follow up in a separate PR/Issue.
Also, E2E tests need a fix.

@AlfredoG87 AlfredoG87 merged commit 060e149 into main Nov 12, 2025
20 of 26 checks passed
@AlfredoG87 AlfredoG87 deleted the solo-e2e-mn-importer-tag-upgrade branch November 12, 2025 18:48
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##               main    #1589      +/-   ##
============================================
- Coverage     80.76%   80.56%   -0.21%     
+ Complexity     1154     1151       -3     
============================================
  Files           126      126              
  Lines          5417     5417              
  Branches        573      573              
============================================
- Hits           4375     4364      -11     
- Misses          789      801      +12     
+ Partials        253      252       -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Issues related to the CI/CD. github_actions Pull requests that update Github Actions code. Tests issue related to enhancing the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ci): Finish e2e solo integration WF and enable it for automatic testing.

7 participants