fix: Update PublishHandler to close only the stream on BEHIND

[Nana-EC]

Reviewer Notes

Currently the handler closes both the stream and connection when handling BEHIND code.
However, the expectation is the publisher would follow up either with more appropriate block items or a TOO_FAR_BEHIND.
When the publisher does it experiences a socket closed exception

• Update BatchHandleResult to separate shutdown, reset and close stream
• Update handleBlockActionResult() to manage 3 cases in a more coordinate fashion and not call either unnecessarily
• Add API Test scenario that shows publisher no longer observes socket exception

Partially address #1914 but does not attempt to fix the protocol definition as that requires CN coordination and larger changes

Related Issue(s)

Use keywords Fix, Fixes, Fixed, Close, Closes, Closed, Resolve, Resolves, Resolved
to connect an issue to be closed by this pull request.

[ata-nas]

Just some preliminary notes to think about.

[ata-nas]

Not sure if these should be in an else. All these booleans should probably run if they are all true.

[ata-nas]

Not sure if that is the only thing we need to do to close the stream. I remember there were some changes recently that allow us to actually close the stream completely.

[ata-nas]

Just FYI, assertj has some conveniences for zero values, some other very frequently used. So we can do "assertThat(number).isZero();". Non-blocking nit. On another note, instead of calling Collection#size and checking if it is zero, we could simply call assertThat(collection).isEmpty(); as seen in L:618. Again, totally non-blocking nit.

[codecov]

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../block/node/stream/publisher/PublisherHandler.java	84.61%	2 Missing ⚠️

@@             Coverage Diff              @@
##               main    #1915      +/-   ##
============================================
- Coverage     79.48%   79.09%   -0.39%     
- Complexity     1193     1200       +7     
============================================
  Files           128      130       +2     
  Lines          5684     5770      +86     
  Branches        610      616       +6     
============================================
+ Hits           4518     4564      +46     
- Misses          887      924      +37     
- Partials        279      282       +3     

Files with missing lines	Coverage Δ	Complexity Δ
.../block/node/stream/publisher/PublisherHandler.java	89.54% <84.61%> (+0.77%)	57.00 <0.00> (+1.00)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.