Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix hiero dependency runtime to compile time only. #635

Closed
wants to merge 2 commits into from
Closed

fix: attempt to fix hiero dependency runtime to compile time only. #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed07f9
attempt to remove spotbugs on runtime for stream package
AlfredoG87 Feb 13, 2025
d3acf73
Merge branch 'main' into hiero-85
jjohannes Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stream/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ testModuleInfo {
requires("com.google.protobuf.util")
requires("org.junit.jupiter.api")
requires("org.junit.jupiter.params")
requiresStatic("com.github.spotbugs.annotations")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requiresStatic("com.github.spotbugs.annotations")

I think this addition is not necessary. The dependency check might even fail now on this (I rebased this PR to check).

}
2 changes: 1 addition & 1 deletion stream/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@
requires transitive io.grpc;
requires io.grpc.protobuf;
requires org.antlr.antlr4.runtime;
requires static com.github.spotbugs.annotations;
requires static transitive com.github.spotbugs.annotations;
requires static java.annotation;
}
Loading