-
Notifications
You must be signed in to change notification settings - Fork 9
chore: BlockAsLocalFile Persistence Test Plan [Phase 2] #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
53ef22b
to
2ee40ca
Compare
block-node/test-specifications/local-persistence/local-persistence-tp.md
Outdated
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Outdated
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Outdated
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Outdated
Show resolved
Hide resolved
bfb3c5d
to
9a24c4e
Compare
Signed-off-by: Atanas Atanasov <[email protected]>
9a24c4e
to
8c3347a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestions.
I added a few notes
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Outdated
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Outdated
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an end-to-end test plan for BlockAsLocalFile Persistence, outlining various test scenarios to validate block storage, movement, archival, and error handling.
- Added a comprehensive list of test cases covering persistence paths, content verification, cleanup behavior, and archival processes.
- Specifies expected inputs and outputs for each test scenario to ensure system correctness.
Comments suppressed due to low confidence (1)
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md:9
- Missing space between 'retrieve' and
Blocks
. Consider updating to 'retrieveBlocks
' for improved readability.
and retrieve`Blocks` from a local storage. It has several moving parts, like path resolution logic, writer tasks,
block-node/test-specifications/local-persistence/block-as-local-file-persistence-tp.md
Show resolved
Hide resolved
@jsync-swirlds @Nana-EC abandoning this. This PR is severely outdated both for the test plan and for the conversations we have had here. Almost none of what we see here is relevant as we have fully refactored the application, we now have persistence plugins which work differently than before and sometimes produce different e2e results (e.g. before we had an unverified path, but we no longer have, tests related to it are no longer relevant and much more). Still, I will use this PR to get ideas for test cases and scenarios as there are very good points here that can apply to the new implementation after we modify them to fit our needs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #856 +/- ##
============================================
- Coverage 89.20% 88.70% -0.50%
+ Complexity 713 710 -3
============================================
Files 131 131
Lines 3047 3046 -1
Branches 219 219
============================================
- Hits 2718 2702 -16
- Misses 264 279 +15
Partials 65 65 see 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Reviewer Notes
BlockAsLocalFile Persistence (BLFP)
Related Issue(s)
Closes #844