docs: E2E test plan for BN Verification plugin#908
Closed
AlfredoG87 wants to merge 1 commit intomainfrom
Closed
Conversation
AlfredoG87
changed the title
AlfredoG87
changed the title
Nana-EC
reviewed
Mar 28, 2025
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
Looking good, I think you noted one form might be going so the test plan might simplify even more correct?
|
|
||
| - **Naive Tree Hasher:** calculates the root hash of the merkle trees in a synchronous manner and using a simple recursive algorithm. | ||
|
|
||
| - **Concurrent Tree Hasher:** calculates the root hash of the merkle trees in an asynchronous manner using a thread pool to parallelize the calculation as the blocks items are received and leafs are appended to the "merkle tree". |
Contributor
There was a problem hiding this comment.
Q: Is it important to note the logic of parallelization here in case it informs testing approach or is that an implementation not necessary?
|
|
||
| ## Test Scenarios | ||
|
|
||
| | Test Case ID | Test Name | Scenario Description | Expected Behaviour | Input | Output | Implemented (Y/N) | |
Contributor
There was a problem hiding this comment.
Note Test Case ID should be a unique string of sort, as a we want to note it in the code so that an E2E test can be mapped back to the plan
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #908 +/- ##
=========================================
Coverage 88.40% 88.40%
Complexity 723 723
=========================================
Files 132 132
Lines 3096 3096
Branches 230 230
=========================================
Hits 2737 2737
Misses 292 292
Partials 67 67 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Fixes #907