fix: Fix verification test pbj parse exception#994
Merged
jasperpotts merged 1 commit into505-plugins-servicesfrom Apr 10, 2025
Merged
fix: Fix verification test pbj parse exception#994jasperpotts merged 1 commit into505-plugins-servicesfrom
jasperpotts merged 1 commit into505-plugins-servicesfrom
Conversation
AlfredoG87
changed the base branch from
505-plugins-services
to
fix-historic-plugin-loading
AlfredoG87
force-pushed
the
fix-verification-test-pbj-parse-exception
branch
from
57affd3 to
89937b1
Compare
AlfredoG87
changed the base branch from
fix-historic-plugin-loading
to
505-plugins-services
AlfredoG87
added
Bug
…rotobuf Definition Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
AlfredoG87
force-pushed
the
fix-verification-test-pbj-parse-exception
branch
from
89937b1 to
6b862d8
Compare
jasperpotts
approved these changes
Apr 10, 2025
jasperpotts
pushed a commit
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com> Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
jsync-swirlds
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com> Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
jsync-swirlds
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com> Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com> Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com> Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com> Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
By using a newer block the issue goes away, but I wonder if we want this issue to go away or if we accidentally found a regression on PBJ that needs to be fixed. and also a future issue that we need to have tests on place.
Related Issue(s)
Use keywords
Fix, Fixes, Fixed, Close, Closes, Closed, Resolve, Resolves, Resolvedto connect an issue to be closed by this pull request.