Skip to content

test: Files Historic Plugin Unit Tests Pt 2 #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 10, 2025
Merged

test: Files Historic Plugin Unit Tests Pt 2 #996

merged 8 commits into from
Apr 10, 2025

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Apr 10, 2025

Reviewer Notes

  • this pr is semi-finished but has to merge in order to not stall further developments
  • some more tests for the files historic plugin
  • updated the BlockPath to be able to compute an existing path, adding the actual compression used on it (currently only naively checking for the extension)
  • changes to the zip accessor were made to facilitate the block path updates, mainly to be able to correctly read (needs further testing, not asserting currently that it is 100% done, upcoming PRs will assert that)

Related Issue(s)

Closes #990

@ata-nas ata-nas added the pull request label to get past the "label required" check when no label is needed or appropriate. label Apr 10, 2025
@ata-nas ata-nas added this to the 0.9.0 milestone Apr 10, 2025
@ata-nas ata-nas self-assigned this Apr 10, 2025
ata-nas and others added 8 commits April 10, 2025 19:11
@ata-nas
wip, adding some test logic
5a9b84a 
- need to determine what will be the general approach with compression extensions, should they exist or not
- need to determine if we will want to keep the NONE compression type, do we really need it
- depending on above answers, there will be some rework needed

Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
cleanup of block path tests and facilitate easy addition of different…
e56191e 
… configs to test with

Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
semi-working block path
e0e9ed4 
Signed-off-by: Atanas Atanasov <[email protected]>
@jasperpotts @ata-nas
Cleaned up config for zip path to only have one param. Fixed tests an…
5add93b 
…d added a bunch of comments to implementation of computeBlockPath method. Tried hard to make it more obvious :-)

Signed-off-by: jasperpotts <[email protected]>
@ata-nas
adding test case for 6 digits block path
2a00ef6 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotless and formatting
a8f014d 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
rework of the zip file accessor to be agnostic to runtime compression…
af14173 
… type when reading

Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
adding some compression type tests
5f5202a 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas force-pushed the 990-files-historic-plugin-unit-tests-pt-2 branch from 411897a to 5f5202a Compare April 10, 2025 16:12
@ata-nas ata-nas linked an issue Apr 10, 2025 that may be closed by this pull request
Files Historic Plugin Unit Tests Pt. 2 #990
Closed
@jasperpotts jasperpotts marked this pull request as ready for review April 10, 2025 16:38
@jasperpotts jasperpotts requested review from a team as code owners April 10, 2025 16:38
@jasperpotts jasperpotts requested a review from AlfredoG87 April 10, 2025 16:38
@jasperpotts jasperpotts merged commit 0966a84 into 505-plugins-services Apr 10, 2025
5 of 7 checks passed
@jasperpotts jasperpotts deleted the 990-files-historic-plugin-unit-tests-pt-2 branch April 10, 2025 16:38
jasperpotts added a commit that referenced this pull request Apr 11, 2025
@ata-nas @jasperpotts
test: Files Historic Plugin Unit Tests Pt 2 (#996)
d627d5c 
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Co-authored-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
jsync-swirlds pushed a commit that referenced this pull request Apr 17, 2025
@ata-nas @jasperpotts @jsync-swirlds
test: Files Historic Plugin Unit Tests Pt 2 (#996)
4c4ee10 
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Co-authored-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
jsync-swirlds pushed a commit that referenced this pull request Apr 17, 2025
@ata-nas @jasperpotts @jsync-swirlds
test: Files Historic Plugin Unit Tests Pt 2 (#996)
87c83e2 
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Co-authored-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
jsync-swirlds pushed a commit that referenced this pull request Apr 17, 2025
@ata-nas @jasperpotts @jsync-swirlds
test: Files Historic Plugin Unit Tests Pt 2 (#996)
2748825 
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Co-authored-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperpotts jasperpotts jasperpotts approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87 AlfredoG87 was automatically assigned from hiero-ledger/hiero-block-node-maintainers

Assignees

@ata-nas ata-nas

Labels
pull request label to get past the "label required" check when no label is needed or appropriate.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Files Historic Plugin Unit Tests Pt. 2
2 participants
@ata-nas @jasperpotts