-
Notifications
You must be signed in to change notification settings - Fork 80
feat: change eth_maxPriorityFeePerGas to return UNSUPPORTED_METHOD #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 19 files - 5 245 suites - 85 37m 1s ⏱️ - 10m 21s For more details on these failures, see this check. Results for commit 38c3bfc. ± Comparison against base commit 4fa65dc. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let’s confirm that Fer is also aware of this, as updating a 200 HTTP response to a 400 could be a breaking change.
@@ -84,7 +84,10 @@ describe('@ethCommon', async function () { | |||
|
|||
it('should execute "eth_maxPriorityFeePerGas"', async function () { | |||
const result = await relay.eth().maxPriorityFeePerGas(requestDetails); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the await can be dropped
Description:
This PR changes eth_maxPriorityFeePerGas to return UNSUPPORTED_METHOD
Related issue(s):
Fixes #3487
Checklist