Skip to content

feat: change eth_maxPriorityFeePerGas to return UNSUPPORTED_METHOD #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Apr 16, 2025

Description:
This PR changes eth_maxPriorityFeePerGas to return UNSUPPORTED_METHOD

Related issue(s):

Fixes #3487

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@simzzz simzzz requested review from a team as code owners April 16, 2025 12:58
@simzzz simzzz requested a review from Ferparishuertas April 16, 2025 12:58
Copy link

github-actions bot commented Apr 16, 2025

Test Results

 19 files   -   5  245 suites   - 85   37m 1s ⏱️ - 10m 21s
629 tests  -   5  622 ✅ + 10  4 💤 ±0  3 ❌  - 15 
653 runs   - 351  646 ✅  - 334  4 💤 ±0  3 ❌  - 17 

For more details on these failures, see this check.

Results for commit 38c3bfc. ± Comparison against base commit 4fa65dc.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
"before all" hook for "@release should execute "eth_getTransactionCount" primary" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_getTransactionCount "before all" hook for "@release should execute "eth_getTransactionCount" primary"
"before all" hook for "Function calling HederaTokenService.isToken(token)" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call with contract that calls precompiles "before all" hook for "Function calling HederaTokenService.isToken(token)"
"before all" hook for "should individually update amountSpents of different spending plans" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch1 Multiple users with different tiers "before all" hook for "should individually update amountSpents of different spending plans"
"before all" hook: beforeFunc for "001 Should call pureMultiply" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address "before all" hook: beforeFunc for "001 Should call pureMultiply"
"before all" hook: beforeFunc for "001 Should call pureMultiply" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address "before all" hook: beforeFunc for "001 Should call pureMultiply"
should execute "eth_maxPriorityFeePerGas" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests @release Hardcoded RPC Endpoints should execute "eth_maxPriorityFeePerGas"
should not support "eth_maxPriorityFeePerGas" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests @release Unsupported RPC Endpoints should not support "eth_maxPriorityFeePerGas"

♻️ This comment has been updated with latest results.

@simzzz simzzz self-assigned this Apr 16, 2025
@simzzz simzzz added the enhancement New feature or request label Apr 16, 2025
@simzzz simzzz added this to the 0.68.0 milestone Apr 16, 2025
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let’s confirm that Fer is also aware of this, as updating a 200 HTTP response to a 400 could be a breaking change.

@@ -84,7 +84,10 @@ describe('@ethCommon', async function () {

it('should execute "eth_maxPriorityFeePerGas"', async function () {
const result = await relay.eth().maxPriorityFeePerGas(requestDetails);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the await can be dropped

@simzzz simzzz closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate implementation for eth_maxPriorityFeePerGas
3 participants