Skip to content

fix: removed Consensus Node fallback mechanism for read-only RPC methods #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 23, 2025
Merged

fix: removed Consensus Node fallback mechanism for read-only RPC methods #3715

merged 9 commits into from
Apr 23, 2025

Conversation

quiet-node
Copy link
Contributor

Description:

  • Removed all CN fallback mechanisms from read-only RPC methods, making them truly cost-free.
  • Updated setQueryParam() to ignore null, undefined, and empty string values, preventing invalid parameters from being sent to the MN, which would cause it to reject requests with a 400 Invalid Params error.

Fixes #3713

@quiet-node quiet-node added the enhancement New feature or request label Apr 22, 2025
@quiet-node quiet-node added this to the 0.68.0 milestone Apr 22, 2025
@quiet-node quiet-node self-assigned this Apr 22, 2025
@quiet-node quiet-node requested review from a team as code owners April 22, 2025 18:39
@quiet-node quiet-node linked an issue Apr 22, 2025 that may be closed by this pull request
Remove Consensus Node fallback mechanism to make read-only RPC methods truly cost-free #3713
Closed
@quiet-node quiet-node changed the title fix: remove Consensus Node fallbacks from read-only RPC methods to ensure zero HBAR cost fix: removed Consensus Node fallback mechanism for read-only RPC methods Apr 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

Test Results

 18 files   -   2  237 suites   - 18   34m 44s ⏱️ - 6m 5s
629 tests ±  0  625 ✅ +  4  4 💤 ±0  0 ❌  - 4 
645 runs   - 170  641 ✅  - 166  4 💤 ±0  0 ❌  - 4 

Results for commit 39db1e5. ± Comparison against base commit b882f71.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 3713-remove-consensus-node-fallbacks-to-make-read-only-rpc-methods-truly-cost-free branch from eb33191 to c995e53 Compare April 22, 2025 19:25
acuarica
acuarica reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, left a couple of comments/questions

quiet-node and others added 4 commits April 23, 2025 12:16
@quiet-node @acuarica
fix: update log content for better context
f1c6bb1 
Signed-off-by: Logan Nguyen <[email protected]>

Co-authored-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
chore: removed unnecessary comment
024fd71 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
chore: updated test
b522af2 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
chore: removed unused constants
39db1e5 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node force-pushed the 3713-remove-consensus-node-fallbacks-to-make-read-only-rpc-methods-truly-cost-free branch from a938f60 to 39db1e5 Compare April 23, 2025 16:25
Ferparishuertas
Ferparishuertas approved these changes Apr 23, 2025
View reviewed changes
Copy link

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node quiet-node merged commit 014f26f into main Apr 23, 2025
39 checks passed
@quiet-node quiet-node deleted the 3713-remove-consensus-node-fallbacks-to-make-read-only-rpc-methods-truly-cost-free branch April 23, 2025 17:48
@quiet-node quiet-node mentioned this pull request Apr 25, 2025
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferparishuertas Ferparishuertas Ferparishuertas approved these changes

@acuarica acuarica acuarica approved these changes

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.68.0
Development

Successfully merging this pull request may close these issues.

Remove Consensus Node fallback mechanism to make read-only RPC methods truly cost-free
3 participants
@quiet-node @Ferparishuertas @acuarica