-
Notifications
You must be signed in to change notification settings - Fork 80
feat: support non-zero shard/realm #3718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support non-zero shard/realm #3718
Conversation
Test Results 21 files + 1 261 suites +10 41m 55s ⏱️ + 1m 4s For more details on these failures, see this check. Results for commit 3985e43. ± Comparison against base commit 014f26f. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
a99025f
to
3985e43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work!
Description:
This PR adds preliminary support for non-zero shard/realm numbers. As described in #3614, it was mostly related to
eth_getCode
and the redirect bytecode. This was refactored to avoid duplication.In addition it now includes
0x
hex prefix in the HTS redirect bytecode. The spec indicated thateth_getCode
result response should be a hex encoded value starting with0x
.Related issue(s):
Fixes #3614
Notes for reviewer:
Checklist