Skip to content

feat: support non-zero shard/realm #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Apr 23, 2025

Description:

This PR adds preliminary support for non-zero shard/realm numbers. As described in #3614, it was mostly related to eth_getCode and the redirect bytecode. This was refactored to avoid duplication.

In addition it now includes 0x hex prefix in the HTS redirect bytecode. The spec indicated that eth_getCode result response should be a hex encoded value starting with 0x.

Related issue(s):

Fixes #3614

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica self-assigned this Apr 23, 2025
@acuarica acuarica added the enhancement New feature or request label Apr 23, 2025
Copy link

github-actions bot commented Apr 23, 2025

Test Results

 21 files  + 1  261 suites  +10   41m 55s ⏱️ + 1m 4s
632 tests + 2  623 ✅  -  1  4 💤 ±0  5 ❌ +3 
795 runs  +65  786 ✅ +62  4 💤 ±0  5 ❌ +3 

For more details on these failures, see this check.

Results for commit 3985e43. ± Comparison against base commit 014f26f.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
"before all" hook in "RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Acceptance Tests "before all" hook in "RPC Server Acceptance Tests"
"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"
"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"

♻️ This comment has been updated with latest results.

@acuarica acuarica added this to the 0.68.0 milestone Apr 23, 2025
@acuarica acuarica marked this pull request as ready for review April 23, 2025 17:07
@acuarica acuarica requested review from a team as code owners April 23, 2025 17:07
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica force-pushed the 3614-ensure-relay-is-compatible-with-accounts-contracts-and-tokens-with-non-zero-shardrealm-numbers branch from a99025f to 3985e43 Compare April 23, 2025 18:44
Copy link

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@acuarica acuarica merged commit a9fc75b into main Apr 25, 2025
38 of 39 checks passed
@acuarica acuarica deleted the 3614-ensure-relay-is-compatible-with-accounts-contracts-and-tokens-with-non-zero-shardrealm-numbers branch April 25, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Relay is compatible with accounts, contracts and tokens with non-zero shard/realm numbers
3 participants