fix: fixes check to remove duplicates from transactionArray #3731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 22 files + 2 289 suites +34 41m 32s ⏱️ +3s For more details on these failures, see this check. Results for commit fabe373. ± Comparison against base commit dbc5f68. ♻️ This comment has been updated with latest results. |
quiet-node
reviewed
Apr 28, 2025
Signed-off-by: Simeon Nakov <[email protected]>
simzzz
requested review from
quiet-node,
Ferparishuertas,
acuarica,
natanasow and
konstantinabl
Signed-off-by: Simeon Nakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a problem in the
getBlock()method which caused duplicate transactions to be returned.The old code
transactionArray = showDetails ? transactionArray : _.uniq(transactionArray);didn't account for the situation where duplicate transaction could be returned in some cases where one transaction emits multiple events (e.g. minting multiple NFT serials in one transaction). In that case, duplicate transactions would be generated from the logs. I have changed this line to account for that and exclude duplicates.Related issue(s):
Fixes #3724
Notes for reviewer:
Checklist