Skip to content

Conversation

@georgi-l95
Copy link
Member

Switch license declarations to SPDX

Related issue(s):

Fixes #899

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 self-assigned this Jan 10, 2025
@georgi-l95 georgi-l95 requested a review from dalvizu January 10, 2025 13:39
@georgi-l95 georgi-l95 linked an issue Jan 10, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.15%. Comparing base (7ad0f45) to head (c7e728b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files          29       29           
  Lines        1179     1179           
  Branches      147      147           
=======================================
  Hits          721      721           
  Misses        437      437           
  Partials       21       21           
Files with missing lines Coverage Δ
src/Errors/LocalNodeErrors.ts 55.55% <ø> (ø)
src/configuration/types/IPrivateKey.ts 72.72% <ø> (ø)
src/constants.ts 100.00% <ø> (ø)
src/controller/StateController.ts 80.55% <ø> (ø)
src/data/ConfigurationData.ts 66.66% <ø> (ø)
src/data/StateData.ts 47.61% <ø> (ø)
src/services/CLIService.ts 5.68% <ø> (ø)
src/services/ClientService.ts 35.29% <ø> (ø)
src/services/ConnectionService.ts 17.94% <ø> (ø)
src/services/DockerService.ts 8.86% <ø> (ø)
... and 19 more

Impacted file tree graph

Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
mishomihov00
mishomihov00 previously approved these changes Jan 13, 2025
andrewb1269
andrewb1269 previously approved these changes Jan 13, 2025
Copy link
Contributor

@andrewb1269 andrewb1269 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve workflow files.

Signed-off-by: georgi-l95 <[email protected]>
@georgi-l95 georgi-l95 dismissed stale reviews from andrewb1269 and mishomihov00 via 32af81c January 15, 2025 08:34
Signed-off-by: georgi-l95 <[email protected]>
@sonarqubecloud
Copy link

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve workflow files.

@georgi-l95 georgi-l95 merged commit 3099354 into main Jan 15, 2025
15 checks passed
@georgi-l95 georgi-l95 deleted the 899-switch-license-declarations-to-spdx branch January 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch license declarations to SPDX

7 participants