Skip to content

HIP-1215 Add integration tests for the new schedule functions#12257

Merged
steven-sheehy merged 4 commits intomainfrom
11651-schedule-service-new-functions
Oct 28, 2025
Merged

HIP-1215 Add integration tests for the new schedule functions#12257
steven-sheehy merged 4 commits intomainfrom
11651-schedule-service-new-functions

Conversation

@bilyana-gospodinova
Copy link
Copy Markdown
Contributor

@bilyana-gospodinova bilyana-gospodinova commented Oct 23, 2025

Description:
This PR adds integration tests for the new functions provided in the Hedera Schedule service:

  • IHederaScheduleService.scheduleCall
  • IHederaScheduleService.scheduleCallWithPayer
  • IHederaScheduleService.executeCallOnPayerSignature
  • IHederaScheduleService.deleteSchedule
  • IHederaScheduleService.hasScheduleCapacity

An abstract class (AbstractContractCallScheduleTest) is created in this PR in order to contain some common methods for the schedule tests.

Fixes #11651

@bilyana-gospodinova bilyana-gospodinova self-assigned this Oct 23, 2025
@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature web3 Area: Web3 API labels Oct 23, 2025
@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Oct 27, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-31.93% (target: -1.00%) 40.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1991e40) 36936 33645 91.09%
Head commit (689c17e) 61748 (+24812) 36528 (+2883) 59.16% (-31.93%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12257) 5 2 40.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@steven-sheehy steven-sheehy added this to the 0.142.0 milestone Oct 27, 2025
@steven-sheehy
Copy link
Copy Markdown
Contributor

0.67 proto has been merged

Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 11651-schedule-service-new-functions branch from eda8b1e to b923328 Compare October 28, 2025 10:49
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review October 28, 2025 10:52
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner October 28, 2025 10:52
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Copy link
Copy Markdown
Contributor

@sdimitrov9 sdimitrov9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 7bb05a4 into main Oct 28, 2025
32 of 34 checks passed
@steven-sheehy steven-sheehy deleted the 11651-schedule-service-new-functions branch October 28, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature web3 Area: Web3 API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HIP-1215: IHederaScheduleService new functions support

4 participants