Skip to content

feat: implemented rest of the TCK endpt for FileService.#1252

Merged
rwalworth merged 4 commits intohiero-ledger:mainfrom
Adityarya11:feat/remaining-file-TCK-endpt
Mar 19, 2026
Merged

feat: implemented rest of the TCK endpt for FileService.#1252
rwalworth merged 4 commits intohiero-ledger:mainfrom
Adityarya11:feat/remaining-file-TCK-endpt

Conversation

@Adityarya11
Copy link
Copy Markdown
Contributor

Description:
Implemented the remainig FileService TCK endpoint.

  • AppendFile
  • GetFileInfo
  • GetFileContents

Related issue(s):

Fixes #1245 #1244 #1243

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link
Copy Markdown

Hey @Adityarya11 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1245 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 18, 2026
@Adityarya11 Adityarya11 requested a review from rwalworth March 18, 2026 07:17
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Adityarya11! Great to see the remaining FileService TCK endpoints coming together - the overall structure follows the existing patterns well. I left a few comments below. There are two spots where non-optional fields are used with .has_value() / .value() which would cause compilation errors, plus a handful of copy-paste artifacts to clean up. Once those are addressed we should be good to go!

Signed-off-by: Aditya Arya <arya050411@gmail.com>
Signed-off-by: Aditya Arya <arya050411@gmail.com>
Signed-off-by: Aditya Arya <arya050411@gmail.com>
@Adityarya11 Adityarya11 force-pushed the feat/remaining-file-TCK-endpt branch from 117bdc6 to 72be666 Compare March 19, 2026 03:31
@Adityarya11 Adityarya11 requested a review from rwalworth March 19, 2026 03:32
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work addressing all the feedback from the last review, @Adityarya11! The compilation fixes look good, the cleanup came through, and the overall structure follows the existing patterns well.

There are a couple of tiny leftover doc comment nits. Feel free to address them here if you'd like, otherwise I can create follow-up good first issues for them - either way works! I will merge once the workflows pass.

@rwalworth rwalworth merged commit ba83974 into hiero-ledger:main Mar 19, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Implement getFileInfo TCK endpoint

2 participants