feat: implemented rest of the TCK endpt for FileService.#1252
feat: implemented rest of the TCK endpt for FileService.#1252rwalworth merged 4 commits intohiero-ledger:mainfrom
Conversation
|
Hey @Adityarya11 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1245 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
rwalworth
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Adityarya11! Great to see the remaining FileService TCK endpoints coming together - the overall structure follows the existing patterns well. I left a few comments below. There are two spots where non-optional fields are used with .has_value() / .value() which would cause compilation errors, plus a handful of copy-paste artifacts to clean up. Once those are addressed we should be good to go!
Signed-off-by: Aditya Arya <arya050411@gmail.com>
Signed-off-by: Aditya Arya <arya050411@gmail.com>
Signed-off-by: Aditya Arya <arya050411@gmail.com>
117bdc6 to
72be666
Compare
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - nice work addressing all the feedback from the last review, @Adityarya11! The compilation fixes look good, the cleanup came through, and the overall structure follows the existing patterns well.
There are a couple of tiny leftover doc comment nits. Feel free to address them here if you'd like, otherwise I can create follow-up good first issues for them - either way works! I will merge once the workflows pass.
Description:
Implemented the remainig FileService TCK endpoint.
AppendFileGetFileInfoGetFileContentsRelated issue(s):
Fixes #1245 #1244 #1243
Notes for reviewer:
Checklist