Open
Conversation
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
6 tasks
|
Hey @gsstoykov 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1274 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
github-actions
bot
added
the
status: needs review
rwalworth
requested changes
Mar 25, 2026
rwalworth
added
status: needs revision
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
github-actions
bot
added
status: needs review
rwalworth
approved these changes
Mar 27, 2026
Contributor
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing the feedback!
rwalworth
added
status: needs revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds proper internal validation.
Related issue(s):
Fixes #1274
Notes for reviewer:
Checklist