feat: added operator == and expand unit test for pendingAirdropld#1293
Conversation
Signed-off-by: Davin <dev.davicheanin@gmail.com>
|
Hey @davin-core 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1267 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
gsstoykov
left a comment
There was a problem hiding this comment.
I know this goes out of the issue scope but shouldn't we maintain the operator for more/all data holders? @rwalworth
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - everything looks great here, @davin-core! The operator== implementation correctly compares all four member fields, and the new tests cover the full range of cases from the issue: NFT fromProtobuf, equality for both FT and NFT, and three distinct inequality scenarios. Running workflows and will merge once they pass!
Absolutely @gsstoykov! You're right that we should add |
…ero-ledger#1293) Signed-off-by: Davin <dev.davicheanin@gmail.com>
Description:
PendingAirdropId.hPendingAirdropId.ccPendingAirdropIdUnitTests.cc:Fixes #1267