Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/helpers/validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function isNonNegativeInteger(value) {
* @returns {boolean}
*/
function isSafeSearchToken(value) {
return typeof value === 'string' && /^[a-zA-Z0-9._/-]+$/.test(value);
return typeof value === 'string' && /^[a-zA-Z0-9._/-]+(\[bot\])?$/.test(value);
}

/**
Expand Down
29 changes: 29 additions & 0 deletions .github/scripts/tests/test-api.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const {
hasLabel,
} = require('../helpers/api');
const { LABELS } = require('../helpers/constants');
const { isSafeSearchToken } = require('../helpers/validation');

// =============================================================================
// MOCK FACTORY
Expand Down Expand Up @@ -457,6 +458,34 @@ const unitTests = [
return calls.labelsRemoved.length === 0 && calls.labelsAdded.length === 0;
},
},

// ---------------------------------------------------------------------------
// SafeSearchToken
// ---------------------------------------------------------------------------
{
name: 'isSafeSearchToken: dependabot[bot] → true',
test: () => isSafeSearchToken('dependabot[bot]') === true,
},
{
name: 'isSafeSearchToken: string with spaces → false',
test: () => isSafeSearchToken('bad username') === false,
},
{
name: 'isSafeSearchToken: string with bad characters → false',
test: () => isSafeSearchToken('bad<username>') === false,
},
{
name: 'isSafeSearchToken: string with bad characters → false',
test: () => isSafeSearchToken('bad;username') === false,
},
{
name: 'isSafeSearchToken: string with brackets but not bot inside → false',
test: () => isSafeSearchToken('bad[admin]') === false,
},
{
name: 'isSafeSearchToken: string with multiple brackets → false',
test: () => isSafeSearchToken('bad[[admin]') === false,
},
];

// =============================================================================
Expand Down
Loading