Skip to content

chore: Update vcpkg#923

Merged
gsstoykov merged 4 commits intomainfrom
00918-update-vcpkg
Apr 15, 2025
Merged

chore: Update vcpkg#923
gsstoykov merged 4 commits intomainfrom
00918-update-vcpkg

Conversation

@gsstoykov
Copy link
Copy Markdown
Contributor

Description:

This PR updates vcpkg and deps.

Related issue(s):

Fixes #918

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Mar 18, 2025
@gsstoykov gsstoykov requested a review from a team March 18, 2025 10:38
@gsstoykov gsstoykov requested review from a team as code owners March 18, 2025 10:38
@gsstoykov gsstoykov linked an issue Mar 18, 2025 that may be closed by this pull request
@gsstoykov
Copy link
Copy Markdown
Contributor Author

openssl/openssl#27084 Linking this as it needs triage in openssl. The KECCAK-256 message digest is throwing an unexpected error when we call ECDSA.sign().

rwalworth
rwalworth previously approved these changes Apr 1, 2025
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rbarker-dev
rbarker-dev previously approved these changes Apr 7, 2025
Copy link
Copy Markdown
Member

@rbarker-dev rbarker-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rwalworth
Copy link
Copy Markdown
Contributor

@gsstoykov OpenSSL 3.5 was released https://github.com/openssl/openssl/releases/tag/openssl-3.5.0. I think we just need to wait for a vcpkg release to contain this now?

@gsstoykov
Copy link
Copy Markdown
Contributor Author

@rwalworth Yep, will keep track

@rwalworth
Copy link
Copy Markdown
Contributor

@gsstoykov https://github.com/microsoft/vcpkg/releases/tag/2025.04.09 looks like it has 3.5.0 of OpenSSL

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov force-pushed the 00918-update-vcpkg branch from d2fe873 to 65eafa6 Compare April 14, 2025 14:24
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov dismissed stale reviews from rbarker-dev and rwalworth via dd31d74 April 15, 2025 13:25
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsstoykov gsstoykov merged commit ee8cda7 into main Apr 15, 2025
7 checks passed
@gsstoykov gsstoykov deleted the 00918-update-vcpkg branch April 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update vcpkg

3 participants