Skip to content

ci: Add clang-format to workflow#933

Merged
gsstoykov merged 16 commits intomainfrom
00833-re-enable-clang-format-checks-in-ci
Apr 4, 2025
Merged

ci: Add clang-format to workflow#933
gsstoykov merged 16 commits intomainfrom
00833-re-enable-clang-format-checks-in-ci

Conversation

@gsstoykov
Copy link
Copy Markdown
Contributor

@gsstoykov gsstoykov commented Apr 3, 2025 •
edited
Loading

Description:

Adds clang-format action.

Related issue(s):

Fixes #833

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov
feat: Add clang-format to workflow
f59cce8 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Apr 3, 2025
@gsstoykov gsstoykov linked an issue Apr 3, 2025 that may be closed by this pull request
Re-enable clang-format checks in CI #833
Closed
gsstoykov added 3 commits April 3, 2025 14:37
@gsstoykov
fix: Moved action after checkout
35cc119 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
feat: Add clang-format on new files
49bd813 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
Mod files rework
cb6e04b 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov changed the title feat: Add clang-format to workflow ci: Add clang-format to workflow Apr 3, 2025
gsstoykov added 10 commits April 3, 2025 14:57
@gsstoykov
ci: Attempt to get file changes
cfb12af 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: Get changes with main
23aad13 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: Added test change
708d4cb 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: Rework modified files workflow
b525392 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: Manage updated files
69d67ea 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: Revert to only using the src dir as input
50b5895 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
ci: clang-format only the core sdk impls to reduce workflow execution
e63f37b 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: Resolve lint issue
a6a04d0 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: format
ead03ad 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: format again
344e86b 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov marked this pull request as ready for review April 3, 2025 13:57
@gsstoykov gsstoykov requested review from a team as code owners April 3, 2025 13:57
gsstoykov added 2 commits April 3, 2025 17:15
@gsstoykov
Add TCK lint path
89cbdff 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
Add lint matrix
198ee6c 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
rwalworth
rwalworth approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsstoykov gsstoykov merged commit 8517c78 into main Apr 4, 2025
8 checks passed
@gsstoykov gsstoykov deleted the 00833-re-enable-clang-format-checks-in-ci branch April 4, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwalworth rwalworth rwalworth approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hiero-ledger/github-maintainers

Assignees

@gsstoykov gsstoykov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-enable clang-format checks in CI

2 participants

@gsstoykov @rwalworth