Skip to content

Comments

chore: added mirror-node and explorer to dual-cluster-full.test.ts, deleted mirror-node.test.ts, bump solo-charts to v0.49.1#1776

Merged
jeromy-cannon merged 5 commits intomainfrom
dual-cluster-full-mirror-explorer
Apr 2, 2025
Merged

chore: added mirror-node and explorer to dual-cluster-full.test.ts, deleted mirror-node.test.ts, bump solo-charts to v0.49.1#1776
jeromy-cannon merged 5 commits intomainfrom
dual-cluster-full-mirror-explorer

Conversation

@jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Apr 1, 2025

Description

This pull request changes the following:

  • added mirror-node and explorer to dual-cluster-full.test.ts
  • deleted the E2E mirror-node.test.ts and corresponding GitHub workflow calls
  • bump solo-charts to v0.49.1 to fix issue encountered with Mirror Node trying to read from Minio

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • N/A

The following was not tested:

  • N/A
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

@jeromy-cannon jeromy-cannon self-assigned this Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Unit Test Results - Linux

24 tests  ±0   24 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a66220a. ± Comparison against base commit d50ab5b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Unit Test Results - Windows

  1 files  ±0   70 suites  ±0   6s ⏱️ +3s
289 tests ±0  289 ✅ ±0  0 💤 ±0  0 ❌ ±0 
294 runs  ±0  294 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a66220a. ± Comparison against base commit d50ab5b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

E2E Test Report

 17 files   -  1  117 suites   - 5   1h 27m 11s ⏱️ - 4m 35s
309 tests  - 16  309 ✅  - 16  0 💤 ±0  0 ❌ ±0 
326 runs   - 18  326 ✅  - 18  0 💤 ±0  0 ❌ ±0 

Results for commit a66220a. ± Comparison against base commit d50ab5b.

This pull request removes 17 and adds 1 tests. Note that renamed tests count towards both.
Account creation should succeed ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand Account creation should succeed
Balance query should succeed ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand Balance query should succeed
Check submit message result should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand Check submit message result should success
Create topic and submit message should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand Create topic and submit message should success
Explorer GUI should be running ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand Explorer GUI should be running
generate key files ‑ E2E Test Suite for 'mirror-cmd-e2e' Bootstrap network for test [release v0.59.5] generate key files
mirror node API should be running ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand mirror node API should be running
mirror node and explorer deploy should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand mirror node and explorer deploy should success
mirror node destroy should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand mirror node destroy should success
node log command should work ‑ E2E Test Suite for 'mirror-cmd-e2e' Bootstrap network for test [release v0.59.5] node log command should work
…
dual-cluster-full: explorer deploy ‑ Dual Cluster Full E2E Test dual-cluster-full: explorer deploy

♻️ This comment has been updated with latest results.

@codacy-production
Copy link

codacy-production bot commented Apr 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.44% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d50ab5b) 34822 29453 84.58%
Head commit (a66220a) 34822 (+0) 28953 (-500) 83.15% (-1.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1776) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (d50ab5b) to head (a66220a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
- Coverage   83.54%   82.14%   -1.41%     
==========================================
  Files         243      243              
  Lines       34822    34822              
  Branches     3411     2293    -1118     
==========================================
- Hits        29093    28605     -488     
- Misses       5458     6177     +719     
+ Partials      271       40     -231     
Files with missing lines Coverage Δ
version.ts 81.25% <100.00%> (ø)

... and 93 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeromy-cannon jeromy-cannon marked this pull request as ready for review April 1, 2025 21:11
@jeromy-cannon jeromy-cannon requested review from a team as code owners April 1, 2025 21:11
@jeromy-cannon jeromy-cannon added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Apr 1, 2025
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…ead method

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon force-pushed the dual-cluster-full-mirror-explorer branch from d9b75de to a66220a Compare April 2, 2025 06:52
@jeromy-cannon jeromy-cannon merged commit 8e8606c into main Apr 2, 2025
44 of 50 checks passed
@jeromy-cannon jeromy-cannon deleted the dual-cluster-full-mirror-explorer branch April 2, 2025 11:57
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.36.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Needs Manager Approval A pull request that needs review from a manager. PR: Needs Team Approval A pull request that needs review from a team member. released on @alpha released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants