Skip to content

fix: update mirror value files to use default redis for mirror importer and grpc #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Apr 4, 2025

Description

This pull request changes the following:

  • update mirror value files to use default redis for mirror importer and grpc

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from a team as code owners April 4, 2025 15:00
@JeffreyDallas JeffreyDallas changed the title fix: update mirror value files to redis for mirror importer and grpc fix: update mirror value files to use default redis for mirror importer and grpc Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Unit Test Results - Linux

24 tests  ±0   24 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9514306. ± Comparison against base commit 2368495.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Unit Test Results - Windows

  1 files  ±0   70 suites  ±0   3s ⏱️ ±0s
290 tests ±0  290 ✅ ±0  0 💤 ±0  0 ❌ ±0 
295 runs  ±0  295 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9514306. ± Comparison against base commit 2368495.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

E2E Test Report

 17 files  ±0  117 suites  ±0   1h 26m 52s ⏱️ -50s
309 tests ±0  309 ✅ ±0  0 💤 ±0  0 ❌ ±0 
326 runs  ±0  326 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9514306. ± Comparison against base commit 2368495.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

E2E Test Report

 17 files  ±0  117 suites  ±0   1h 26m 52s ⏱️ -50s
309 tests ±0  309 ✅ ±0  0 💤 ±0  0 ❌ ±0 
326 runs  ±0  326 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9514306. ± Comparison against base commit 2368495.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2368495) 34766 28919 83.18%
Head commit (9514306) 34766 (+0) 28919 (+0) 83.18% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1809) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (2368495) to head (9514306).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1809    +/-   ##
========================================
  Coverage   82.18%   82.18%            
========================================
  Files         243      243            
  Lines       34766    34766            
  Branches     2298     2162   -136     
========================================
  Hits        28571    28571            
- Misses       6067     6165    +98     
+ Partials      128       30    -98     

see 29 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeffreyDallas JeffreyDallas merged commit ec1a25f into main Apr 4, 2025
48 of 54 checks passed
@JeffreyDallas JeffreyDallas deleted the 01725-D-mirror-redis branch April 4, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch mirror importer and grpc to use redis
2 participants