Skip to content

chore: add remote config data layer classes and migration #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Apr 21, 2025

Description

This pull request changes the following:

  • adds ConfigMapStorageBackend
  • adds YamlConfigMapStorageBackend
  • adds RemoteConfigSource
  • adds RemoteConfigSchema
  • adds RemoteConfigV1Migration

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

jeromy-cannon and others added 11 commits April 17, 2025 11:55
Signed-off-by: Jeromy Cannon <[email protected]>
…emote configuration management

Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@jeromy-cannon jeromy-cannon self-assigned this Apr 21, 2025
@jeromy-cannon jeromy-cannon force-pushed the data-layer-remote-config-and-config-map branch from a847c99 to c48989e Compare April 21, 2025 19:30
Copy link
Contributor

github-actions bot commented Apr 21, 2025

Unit Test Results - Linux

24 tests  ±0   24 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2abde34. ± Comparison against base commit 6785846.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add unit tests
  • finish remote config migration logic with updated remote config

Copy link
Contributor

github-actions bot commented Apr 21, 2025

Unit Test Results - Windows

  1 files  ± 0   81 suites  +11   5s ⏱️ +2s
327 tests +37  327 ✅ +37  0 💤 ±0  0 ❌ ±0 
332 runs  +37  332 ✅ +37  0 💤 ±0  0 ❌ ±0 

Results for commit 2abde34. ± Comparison against base commit 6785846.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Apr 22, 2025
Copy link
Contributor

E2E Test Report

 17 files  ±0  119 suites  ±0   1h 27m 24s ⏱️ + 1m 39s
310 tests ±0  310 ✅ ±0  0 💤 ±0  0 ❌ ±0 
326 runs  ±0  326 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2abde34. ± Comparison against base commit 6785846.

Copy link
Contributor

E2E Test Report

 17 files  ±0  119 suites  ±0   1h 27m 24s ⏱️ + 1m 39s
310 tests ±0  310 ✅ ±0  0 💤 ±0  0 ❌ ±0 
326 runs  ±0  326 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2abde34. ± Comparison against base commit 6785846.

@JeffreyDallas JeffreyDallas marked this pull request as ready for review April 23, 2025 20:56
@JeffreyDallas JeffreyDallas requested a review from a team as a code owner April 23, 2025 20:56
phase: 'started',
});
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add the rest of the migration logic for the mirror nodes, relay nodes, haproxies, envoy proxies, and explorers. I got the updated remote config yaml from Nathan after writing this first version.

commandHistory:
- deployment create
lastExecutedCommand: deployment create
- "Executed by [email protected]: network deploy --deployment alpha-prod
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. Let us do a search replace on [email protected] and change it to something like [email protected]

/Users/nathan.klick/Git/swirldslabs/hashsphere-infrastructure/deployments/p\
roduction/google/hashsphere-production/sphere-alpha-prod/assets/solo/settin\
gs.txt --log4j2-xml
/Users/nathan.klick/Git/swirldslabs/hashsphere-infrastructure/deployments/p\
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search/replace /Users/nathan.klick/Git/swirldslabs/hashsphere-infrastructure/deployments/p\ roduction/google/hashsphere-production/sphere-alpha-prod to something like this: /Users/user/solo-dir

@jeromy-cannon jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals. PR: Unresolved Comments A pull request where there are comments and they need to be resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants