Fix getting licenses on Android. by nic-bell · Pull Request #184 · hierynomus/license-gradle-plugin

nic-bell · 2020-04-17T12:04:56Z

Licenses were always coming up blank on Android used some logic from oss-licenses-plugin.

Tested with following config in root build.gradle.

buildscript {
    ...
    repositories {
        ...
        maven { url "https://jitpack.io" }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.6.1'
        ...
        classpath "com.github.nic-bell:license-gradle-plugin:cac7e1c79a"
    }
}

allprojects {
    ...
    apply plugin: "com.github.hierynomus.license-report"
}

downloadLicenses {
    includeProjectDependencies = true
    dependencyConfiguration = 'releaseRuntimeClasspath'
}

Should fix #174 #182

michallaskowski · 2020-05-13T11:28:33Z

Hi. Any chance on replaying the job on CI, and merging? We tested the changes here, and it works on our Android project. We got 403 dependencies vs 0 with previous versions.

jakubvimn

This is a great work and fixed the plugin for my Android project. All my comments are rather minor improvements that can be done in the code. I haven't found any serious problems.

jakubvimn · 2020-05-13T09:22:07Z

build.gradle

+    }
+    dependencies {
+        classpath "com.gradle.publish:plugin-publish-plugin:0.9.1"
+        classpath 'com.netflix.nebula:gradle-extra-configurations-plugin:2.2.+'


don't use "+", specify concrete version

jakubvimn · 2020-05-13T09:24:18Z

build.gradle

-      url "https://plugins.gradle.org/m2/"
-      jcenter()
+    repositories {
+        maven { url "https://plugins.gradle.org/m2/" }


can be replaced with gradlePluginPortal()

jakubvimn · 2020-05-13T09:25:14Z

build.gradle

-      jcenter()
+    repositories {
+        maven { url "https://plugins.gradle.org/m2/" }
+        maven { url "https://dl.google.com/dl/android/maven2/" }


can be replaced with google()

jakubvimn · 2020-05-13T09:30:50Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

     * @return whether conf is resolvable
     *
-     * @see <a href="https://docs.gradle.org/3.4/release-notes.html#configurations-can-be-unresolvable">Gradle 3.4 release notes</a>
+     * @see <ahref="https://docs.gradle.org/3.4/release-notes.html#configurations-can-be-unresolvable"    >    Gradle 3.4 release notes</a>


jakubvimn · 2020-05-13T09:33:26Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

+     */
+    protected boolean isTest(Configuration configuration) {
+        boolean isTestConfiguration = (configuration.name.startsWith(TEST_PREFIX) || configuration.name.startsWith(ANDROID_TEST_PREFIX))
+        configuration.hierarchy.each { isTestConfiguration |= TEST_COMPILE.contains(it.name) }


most of the time there's no need to check the full hierarchy
return isTestConfiguration || configuration.hierarchy.any { TEST_COMPILE.contains(it.name) }

jakubvimn · 2020-05-13T09:34:21Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

+        boolean isPackagedDependency = PACKAGED_DEPENDENCIES_PREFIXES.any {
+            configuration.name.startsWith(it)
+        }
+        configuration.hierarchy.each {


isPackagedDependency |= configuration.hierarchy.any ...

jakubvimn · 2020-05-13T09:37:10Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

+
+
+    boolean isDependencyIncluded(String depName) {
+        for (Pattern pattern : this.patternsToIgnore) {


return !patternsToIgnore.any { it.matcher(depName).matches() }

nic-bell · 2020-06-02T14:22:15Z

@jakubvimn I've made some changes based on your feedback.
I think upgrading the Android plugin and Gradle broke AnimalSniffer and maybe some of the tests too. Tried investigating this briefly then resorted to just using the plugin straight off JitPack.

jakubvimn · 2020-06-04T08:36:58Z

build.gradle


+animalsniffer {
+    excludeJars 'gradle-api-*'
+    ignoreFailures true


I have no idea what it doesn't work. I've created an issue for Animals Sniffer
xvik/gradle-animalsniffer-plugin#22

There's a response
xvik/gradle-animalsniffer-plugin#22 (comment)

I guess that after animal sniffer update, this should not be needed anymore.

jakubvimn · 2020-06-04T10:02:47Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

     * @return whether conf is resolvable
     *
-     * @see <a href="https://docs.gradle.org/3.4/release-notes.html#configurations-can-be-unresolvable">Gradle 3.4 release notes</a>
+     * @see <ahref="https://docs.gradle.org/3.4/release-notes.html#configurations-can-be-unresolvable" > Gradle 3.4 release notes</a>


ahref -> a href

jakubvimn · 2020-06-29T13:47:13Z

@nic-bell will you look into the failed build? Do you need any support?

Jeehut · 2020-06-30T15:16:16Z

@michallaskowski How did you get this running from the fork? Can you maybe provide some instructions and gradle code how you integrated it? Couldn't do it using jitpack following these instructions as this is not a library but a plugin. Some help would be much appreciated! @nic-bell

michallaskowski · 2020-06-30T15:23:28Z

@Jeehut I didn't, @jakubvimn did (we work together). I will ensure tomorrow he saw this message, in case he didn't get the notification. Afaik, he published a build from this PR's branch to our internal artifacts repository. I think we all count on this PR being merged, though.

nic-bell · 2020-06-30T20:14:14Z

@nic-bell will you look into the failed build? Do you need any support?

I gave up after I ran into the animal sniffer issue. I am not even sure this repo is actively maintained.

nic-bell · 2020-06-30T20:21:31Z

@michallaskowski How did you get this running from the fork? Can you maybe provide some instructions and gradle code how you integrated it? Couldn't do it using jitpack following these instructions as this is not a library but a plugin. Some help would be much appreciated! @nic-bell

Hey the instructions to try it out are in the original PR description but here they are again anyway. I am using it in Android project as a library.

buildscript {
 ...
  dependencies {
    ...
    repositories {
        ...
        maven { url "https://jitpack.io" }
    }
    classpath "com.github.nic-bell:license-gradle-plugin:a1215e995d"
}

allprojects {
    ...
    apply plugin: "com.github.hierynomus.license-report"
}

downloadLicenses {
    includeProjectDependencies = true
    dependencyConfiguration = 'releaseRuntimeClasspath'
}

For the latest build look here:
https://jitpack.io/#nic-bell/license-gradle-plugin

jakubvimn · 2020-07-01T11:15:15Z

@Jeehut Yes, for our internal use, I just configured maven-publish plugin for our internal nexus and pushed the library there. But I guess that after the response from @nic-bell my help is not needed anymore.

Jeehut · 2020-07-02T15:08:21Z

Thanks to @nic-bell's instructions I was able to set the fork up. But I'm still getting the output message:

No dependencies recognized!

Looks like this is not fixing #174, at least not for me ...

Jeehut · 2020-07-02T15:15:58Z

Okay guys, taking back what I just said, it actually works now after I found the issue with @nic-bell's instructions:

In my project, I don't have a release variant, so I had to replace releaseRuntimeClasspath with productionReleaseRuntimeClasspath in my case, your case may vary. But it works now, thank you! 🎉

jakubvimn · 2020-09-02T13:36:41Z

Any update on that? Do you need any help to move it forward?

anikitin-intermedia · 2021-04-30T14:37:50Z

src/main/groovy/nl/javadude/gradle/plugins/license/LicenseResolver.groovy

            def configuration = project.configurations.getByName(dependencyConfiguration)
-            configuration.resolvedConfiguration.resolvedArtifacts.each { ResolvedArtifact d ->
-                String dependencyDesc = "$d.moduleVersion.id.group:$d.moduleVersion.id.name:$d.moduleVersion.id.version".toString()
-                if(isDependencyIncluded(dependencyDesc)) {


This line does not work in new code, so it's not possible to exclude any project dependency

Khosbayar · 2021-08-27T03:53:03Z

May I know what is the status of this PR?
Seems like a lot of people are facing this issue.

Thanks and looking forward to it.

Mepfic · 2021-09-21T14:21:03Z

Do we have any chance to look this PR merged? Because I faced with this issue too.. Thanks

openkin · 2021-09-21T14:33:54Z

Do we have any chance to look this PR merged? Because I faced with this issue too.. Thanks

Use this version: https://github.com/openkin/license-gradle-plugin
(add to your project: implements "com.github.openkin:license-gradle-plugin:0d9582e233")

Mepfic · 2021-09-21T16:44:40Z

0d9582e

I tried get it this way:
plugins { id "com.github.openkin:license-gradle-plugin" version "0d9582e233" },
but faced with error:
Plugin id contains invalid char ':'

Could you provide more details to implement it? Thanks for your time

anikitin-intermedia · 2021-09-22T03:43:40Z

@Mepfic Try this:
Root build.gradle

buildscript {
    repositories {
        ...
        maven { url 'https://jitpack.io' }
    }
    dependencies {
        classpath "com.github.openkin:license-gradle-plugin:0d9582e233"
    }
}

And then in your module build.gradle:

apply plugin: 'com.github.hierynomus.license-report'

Mepfic · 2021-09-22T08:22:34Z

@Mepfic Try this:
Root build.gradle

buildscript {
    repositories {
        ...
        maven { url 'https://jitpack.io' }
    }
    dependencies {
        classpath "com.github.openkin:license-gradle-plugin:0d9582e233"
    }
}

And then in your module build.gradle:

apply plugin: 'com.github.hierynomus.license-report'

In this case I get a error:
> Could not find com.github.openkin:license-gradle-plugin:0d9582e233. Searched in the following locations: - https://dl.google.com/dl/android/maven2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom - https://repo.maven.apache.org/maven2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom - https://plugins.gradle.org/m2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom

Should I use some special repository?

anikitin-intermedia · 2021-09-22T08:25:15Z

@Mepfic Yes, use the jitpack. I've just updated the comment above

Mepfic · 2021-09-22T08:56:29Z

In this case I get a error:
> Could not find com.github.openkin:license-gradle-plugin:0d9582e233. Searched in the following locations: - https://dl.google.com/dl/android/maven2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom - https://repo.maven.apache.org/maven2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom - https://plugins.gradle.org/m2/com/github/openkin/license-gradle-plugin/0d9582e233/license-gradle-plugin-0d9582e233.pom

Should I use some special repository?

@Mepfic Try this:
Root build.gradle

buildscript {
    repositories {
        ...
        maven { url 'https://jitpack.io' }
    }
    dependencies {
        classpath "com.github.openkin:license-gradle-plugin:0d9582e233"
    }
}

And then in your module build.gradle:

apply plugin: 'com.github.hierynomus.license-report'

@Mepfic Yes, use the jitpack. I've just updated the comment above

Cool, I got license report, btw, in my case (for android) works fine only with next parameters:
downloadLicenses { includeProjectDependencies = true dependencyConfiguration = 'releaseRuntimeClasspath' }
Otherwise I got an empty report.
Thanks

anikitin-intermedia · 2021-09-22T09:26:27Z

@Mepfic Could you try dependencyConfiguration = 'all' ? This settings works in my case

Mepfic · 2021-09-22T11:24:42Z

@Mepfic Could you try dependencyConfiguration = 'all' ? This settings works in my case

yea, it works too (from fork version). In release version 0.16.1 'all' didn't work, only 'releaseRuntimeClasspath' and 'debugRuntimeClasspath' - by my build variants.

anthony-fresneau-kiplin · 2021-11-22T14:02:43Z

Hi,
Is that fix for Android will be merged and released soon?
Thanks and best regards,

anthony-fresneau-kiplin · 2023-05-05T14:11:22Z

Hello, Any updates on this pull request?
Regards

conan · 2024-04-25T13:41:05Z

The forked version worked for me on a test java project (not android). Any chance of this PR being merged?

nic-bell added 12 commits April 17, 2020 09:39

Try support implementation

afee16e

Trying to resolve dependencies.

ea6fac2

Try this.

1618e5b

Config missing

a9434ea

oops

8d20b7c

Log dep count

fcf69d4

Fixed bad count

a2be408

print output

e1bbcca

clean up.

b359677

Better logging.

9ac2124

Hack to show all

213e1da

Another bug.

da8feec

nic-bell marked this pull request as ready for review April 17, 2020 12:16

nic-bell added 5 commits April 17, 2020 18:34

Catch this too.

d582299

Update gradle

14c3497

update scan plugin.

0b400d0

try this.

d977b43

More deps.

cac7e1c

bloopkin approved these changes Apr 30, 2020

View reviewed changes

jakubvimn reviewed May 13, 2020

View reviewed changes

PR feedback.

5cbdf53

Stop sniffing animals.

a1215e9

jakubvimn approved these changes Jun 4, 2020

View reviewed changes

Update animal sniffer version.

0d1bcac

cromefire mentioned this pull request Oct 16, 2020

Make used Gradle SourceSet and Configuration configurable GoogleContainerTools/jib#1778

Closed

anikitin-intermedia reviewed Apr 30, 2021

View reviewed changes

iadcialim mentioned this pull request Jul 8, 2021

Empty report with 'implementation' dependencies #182

Open

dzuluaga mentioned this pull request Jul 14, 2023

Report is empty (Android) #174

Open



		boolean isDependencyIncluded(String depName) {
		for (Pattern pattern : this.patternsToIgnore) {

Conversation

nic-bell commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michallaskowski commented May 13, 2020

Uh oh!

jakubvimn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nic-bell commented Jun 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakubvimn commented Jun 29, 2020

Uh oh!

Jeehut commented Jun 30, 2020

Uh oh!

michallaskowski commented Jun 30, 2020

Uh oh!

nic-bell commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nic-bell commented Jun 30, 2020

Uh oh!

jakubvimn commented Jul 1, 2020

Uh oh!

Jeehut commented Jul 2, 2020

Uh oh!

Jeehut commented Jul 2, 2020

Uh oh!

jakubvimn commented Sep 2, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Khosbayar commented Aug 27, 2021

Uh oh!

Mepfic commented Sep 21, 2021

Uh oh!

openkin commented Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mepfic commented Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anikitin-intermedia commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mepfic commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anikitin-intermedia commented Sep 22, 2021

Uh oh!

Mepfic commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anikitin-intermedia commented Sep 22, 2021

Uh oh!

Mepfic commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nic-bell commented Apr 17, 2020 •

edited

Loading

nic-bell commented Jun 2, 2020 •

edited

Loading

nic-bell commented Jun 30, 2020 •

edited

Loading

openkin commented Sep 21, 2021 •

edited

Loading

Mepfic commented Sep 21, 2021 •

edited

Loading

anikitin-intermedia commented Sep 22, 2021 •

edited

Loading

Mepfic commented Sep 22, 2021 •

edited

Loading

Mepfic commented Sep 22, 2021 •

edited

Loading

Mepfic commented Sep 22, 2021 •

edited

Loading