Skip to content

Support license-maven-plugin-git#212

Open
uyw4687 wants to merge 2 commits intohierynomus:masterfrom
uyw4687:master
Open

Support license-maven-plugin-git#212
uyw4687 wants to merge 2 commits intohierynomus:masterfrom
uyw4687:master

Conversation

@uyw4687
Copy link
Copy Markdown

@uyw4687 uyw4687 commented Oct 1, 2022

fixes #140
most of the codes are from license-maven-plugin
fixed some styles


license {
ignoreFailures = true
inceptionYear = 2011
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inceptionYear is needed while using license-maven-plugin-git


then:
javaFile.text == '''/**
javaFile.text == '''/*
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the format has changed

Comment on lines +125 to +133
provider.init(new com.mycila.maven.plugin.license.AbstractLicenseMojo() {
{
defaultBasedir = baseDir;
}

for (String key : props.keySet()) {
properties.put(key, String.valueOf(props.get(key)));
@Override
public void execute() throws MojoExecutionException, MojoFailureException {
}
}, props);
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractLicenseMojos of maven and gradle plugins are different

@uyw4687
Copy link
Copy Markdown
Author

uyw4687 commented Dec 20, 2022

@hierynomus Though this is a small change, we want to fork and publish in another repository. Please tell us if you have any concerns!

@minwoox
Copy link
Copy Markdown

minwoox commented Dec 23, 2022

Is there anyone who can review this PR and release a new version?
We need this feature so I'm considering forking this repository if there's no one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Year based on Git

2 participants