docs(design): reconcile the TODO through 0.4.0 - #48
Merged
Conversation
Records the 0.4.0 release and Marketplace republish, the upstream pytorch/examples PR, and #46 -- plus a third round of branch cleanup and `v0` moving unattended, which are now reflexes rather than decisions. The entry worth having is the false negative in #46. Detachment first propagated whenever a binding was not provably grad-bearing, treating absence of proof as evidence, which silenced a real leak even when `loss.backward()` was called on the name. Neither check caught it: every TG001 fixture assigns from something resolvable, and a wild scan cannot see a false negative at all, since a true positive that stops firing looks exactly like a false positive that got fixed. 24 reported removals were really 10. So the note is methodological rather than a bug report: a wild scan is evidence about false positives only, and false negatives need fixtures that deliberately exceed what the analysis can resolve. Also files the idea the drifted pre-commit `rev:` pins point at. That is the third instance of publishing instructions we never execute, after the `@v0` tag that did not resolve and `action.yml` missing the Node 20 bump. A job running the documented hook would close the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. Brings
design/TODO.mdup to date with everything shipped since the last reconcile.Recorded:
losses.append(loss)exiting 0 by default and 1 under--fail-on warning.v0moved unattended a third time.The entry worth reading
Detachment first propagated whenever a binding was not provably grad-bearing — absence of proof treated as evidence. That silenced
loss = compute_loss(...)followed bylosses.append(loss), and silenced it even whenloss.backward()was called on the name.Neither check caught it. All 437 tests passed, because every TG001 fixture assigns from something resolvable like
criterion(model(batch), y). And the seven-repo scan reported zero new findings, which is structurally blind: a true positive that stops firing is indistinguishable from a false positive that got fixed. I had reported 24 removals — 14 were findings being silenced, 8 of them genuine. The honest figure is 10.So the note is methodological rather than a bug report: a wild scan is evidence about false positives only. False negatives need fixtures that deliberately exceed what the analysis can resolve, and there are now two.
One idea filed
The drifted pre-commit
rev:pins (v0.1.0indocs/ci.md,v0.2.0in the README) are the third instance of one pattern — instructions we publish and never execute. The first wasuses: highwaterlabs/torch-preflight@v0resolving to nothing; the second wasaction.ymlmissing the Node 20 pin bump every workflow file got. A job that runs the documented hook the wayaction-smoke.ymlruns the documented Action would close the class rather than the instance.