feat: Return chromsizes tileset info#158
Merged
pkerpedjiev merged 7 commits intodevelopfrom Apr 7, 2025
Merged
Conversation
pkerpedjiev
changed the title
manzt
reviewed
Apr 7, 2025
| from pydantic import BaseModel | ||
|
|
||
|
|
||
| class TilesetInfo(BaseModel): |
Member
There was a problem hiding this comment.
I see this is only used in the test. Should that be in the test module only or is this intended as a part of the public API?
manzt
approved these changes
Apr 7, 2025
Member
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of clarifying comments.
test/tiles/chromsizes_test.py
Outdated
|
|
||
| assert tsinfo.max_width > 100 | ||
| assert len(tsinfo.chromsizes) > 2 | ||
| # TODO: Do something with the return value |
Member
There was a problem hiding this comment.
The parsing with the pydantic model is a kind of assertion here, is that what you were thinking wrt to "return value'?
Member
Author
There was a problem hiding this comment.
Oh, I meant to remove that line. Removing in the next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What was changed in this pull request?
Why is it necessary?
Fixes #___
Checklist
black .