feat: enable use_default_attributes for ai-statistics plugin#228
Merged
Conversation
…g template Update ai-statistics WasmPlugin configuration in AI Gateway config template to use use_default_attributes by default. Changes: - Set defaultConfigDisable to false to enable plugin globally - Add defaultConfig with use_default_attributes: true - Remove matchRules completely - plugin now applies globally - Remove generated matchRules loop for all ingresses This makes AI Gateway easier to configure out-of-the-box with sensible defaults for LLM observability that apply to all AI routes automatically.
cffa911 to
0943c0d
Compare
|
CodeReview流程已终止 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update ai-statistics WasmPlugin configuration in AI Gateway config template to use
use_default_attributes: trueby default, making the plugin apply globally with sensible defaults for LLM observability.Motivation
The previous configuration had two issues:
defaultConfigDisable: true)With the new
use_default_attributesfeature in ai-statistics plugin (higress#3427), we can simplify configuration significantly - the plugin now applies globally to all AI routes without needing matchRules.Changes
Configuration Updates
defaultConfigDisablefromtruetofalse- plugin now enabled globallydefaultConfigwithuse_default_attributes: true- uses default attributes automaticallymatchRulescompletely - plugin applies to all routes globallyBefore
After
Benefits
Related Issues