refactor: remove Clawdbot integration logic from get-ai-gateway.sh#235
Merged
johnlanni merged 1 commit intoFeb 1, 2026
Conversation
Moved Clawdbot integration configuration to the higress-clawdbot-integration SKILL in the higress repository for better separation of concerns. **Removed:** - `configureClawdbotIntegration()` function (96 lines) - `checkClawdbot()` function (6 lines) - `installFiles()` generic helper function (25 lines) - Clawdbot-related variable definitions (3 lines): - CLAWDBOT_WORKSPACE - CLAWDBOT_EXTENSIONS_DIR - CLAWDBOT_INTEGRATION_DIR - Clawdbot integration info display in success message (18 lines) - Related function call in runConfigWizard - Related comments **Total lines removed:** 121 **Rationale:** Integration logic is now maintained in the higress repository as an independent script (`configure-clawdbot.sh`) within the higress-clawdbot-integration SKILL. This provides: ✅ Better separation of concerns (setup vs integration) ✅ Easier maintenance (integration logic in one place) ✅ Independent versioning (SKILL can be updated independently) ✅ Clearer documentation flow ✅ Reduced complexity in get-ai-gateway.sh **Migration Path:** Users can now configure Clawdbot integration using: ```bash cd .claude/skills/higress-clawdbot-integration ./configure-clawdbot.sh setup ``` Or manually: ```bash clawdbot models auth login --provider higress ``` **Related:** - Higress PR: higress-group/higress#3435 (higress-clawdbot-integration SKILL update)
|
CodeReview流程已终止 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes Clawdbot integration configuration logic from
get-ai-gateway.shand moves it to the higress-clawdbot-integration SKILL in the higress repository as an independent script.Changes
Removed (121 lines total):
Functions:
configureClawdbotIntegration()(96 lines) - Interactive Clawdbot setupcheckClawdbot()(6 lines) - Clawdbot detectioninstallFiles()(25 lines) - Generic file installerVariable Definitions (3 lines):
CLAWDBOT_WORKSPACECLAWDBOT_EXTENSIONS_DIRCLAWDBOT_INTEGRATION_DIRIntegration Info Display (18 lines):
Function Calls:
configureClawdbotIntegrationcall inrunConfigWizardcheckClawdbotcall in success messageRationale
Separation of Concerns:
Previously, Clawdbot integration logic was embedded in the setup script (
get-ai-gateway.sh). This PR extracts it to a dedicated location:✅ Better Maintenance: Integration logic now lives in the SKILL, easier to update
✅ Independent Versioning: SKILL can be updated without touching setup script
✅ Clearer Documentation: Setup vs integration are separate concerns
✅ Reduced Complexity:
get-ai-gateway.shfocuses solely on gateway deploymentNew Integration Path:
Integration logic is now available in the higress repository as:
.claude/skills/higress-clawdbot-integration/configure-clawdbot.shMigration Guide
Before (integrated):
./get-ai-gateway.sh start # Would auto-detect and configure ClawdbotAfter (separate):
Testing
Verified:
bash -n)configureAutoRoutingfunction intact (was partially affected during removal)Tested deployment:
Result: ✅ Deployment successful, no Clawdbot references in output
Related
configure-clawdbot.shscript to higress-clawdbot-integration SKILLBenefits
✅ Cleaner separation: Setup script vs integration script
✅ Better UX: Users can choose when/if to integrate with Clawdbot
✅ Easier testing: Integration can be tested independently
✅ Reduced coupling: Higress setup doesn't depend on Clawdbot detection
✅ Improved maintainability: Integration logic in SKILL, easier to update
Note: This PR is based on the latest
mainbranch (after PR #219 merge) and creates a clean separation between Higress deployment and Clawdbot integration.