Skip to content

fix: improve MCP tool parameter handling and upgrade agentscope #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomas-Eliot merged 1 commit into from
Mar 20, 2026
Merged

fix: improve MCP tool parameter handling and upgrade agentscope #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...rket-server/src/main/java/com/alibaba/himarket/service/hichat/manager/ChatBotManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,12 @@ private Map<String, ToolMeta> buildToolMetas(Toolkit toolkit) {
*/
private void registerTool(Toolkit toolkit, McpClientWrapper client, McpSchema.Tool tool) {
try {
java.util.Set<String> required =
tool.inputSchema() != null && tool.inputSchema().required() != null
? new java.util.HashSet<>(tool.inputSchema().required())
: java.util.Collections.emptySet();
Map<String, Object> parameters =
McpTool.convertMcpSchemaToParameters(tool.inputSchema());
McpTool.convertMcpSchemaToParameters(tool.inputSchema(), required);
McpTool mcpTool =
new McpTool(
tool.name(),
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/com/alibaba/himarket/service/hichat/service/dashscope/DashScopeImageChatModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public Set<String> getSupportedModels() {
public static class DashScopeImageHttpClient extends DashScopeHttpClient {

public DashScopeImageHttpClient(HttpTransport transport, String apiKey, String baseUrl) {
super(transport, apiKey, baseUrl);
super(transport, apiKey, baseUrl, null, null);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<caffeine.version>3.2.3</caffeine.version>
<guava-retrying.version>2.0.0</guava-retrying.version>
<snakeyaml.version>2.0</snakeyaml.version>
<agentscope.version>1.0.6</agentscope.version>
<agentscope.version>1.0.10</agentscope.version>
<jackson-databind.version>2.17.2</jackson-databind.version>
<openai.java.version>4.6.1</openai.java.version>
<dashscope.java.version>2.22.4</dashscope.java.version>
Expand Down
Loading