Skip to content

fix: correct image names and namespace in build workflow #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomas-Eliot merged 2 commits into from
Mar 20, 2026
Merged

fix: correct image names and namespace in build workflow #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
748895c
fix: correct image names and namespace in build workflow
lexburner Mar 20, 2026
be81e70
fix: correct JS template literal syntax in build summary
lexburner Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/build-image-and-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:
env:
# Default registry (can be overridden by repository variables)
IMAGE_REGISTRY: ${{ vars.IMAGE_REGISTRY || 'opensource-registry.cn-hangzhou.cr.aliyuncs.com' }}
IMAGE_NAMESPACE: ${{ vars.IMAGE_NAMESPACE || 'himarket' }}
IMAGE_NAMESPACE: ${{ vars.IMAGE_NAMESPACE || 'higress-group' }}

jobs:
# ===========================================
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
id: docker-meta
uses: docker/metadata-action@v5
with:
images: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-backend
images: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-server
tags: |
type=sha
type=ref,event=tag
Expand All @@ -89,7 +89,7 @@ jobs:
run: |
echo "## 🐳 Backend Image Build" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "**Image**: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-backend\`" >> $GITHUB_STEP_SUMMARY
echo "**Image**: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-server\`" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "**Tags**:" >> $GITHUB_STEP_SUMMARY
echo "${{ steps.docker-meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY
Expand Down Expand Up @@ -273,7 +273,7 @@ jobs:
id: docker-meta
uses: docker/metadata-action@v5
with:
images: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-sandbox
images: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/sandbox
tags: |
type=sha
type=ref,event=tag
Expand All @@ -296,7 +296,7 @@ jobs:
run: |
echo "## 🐳 Sandbox Image Build" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "**Image**: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-sandbox\`" >> $GITHUB_STEP_SUMMARY
echo "**Image**: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/sandbox\`" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "**Tags**:" >> $GITHUB_STEP_SUMMARY
echo "${{ steps.docker-meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY
Expand Down Expand Up @@ -356,10 +356,10 @@ jobs:
if (allPassed) {
summary += '🎉 **All images built and pushed successfully!**\n\n';
summary += '### 📦 Images\n\n';
summary += `- Backend: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-backend:latest\`\n';
summary += `- Admin Portal: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-admin:latest\`\n';
summary += `- Developer Portal: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-frontend:latest\`\n';
summary += `- Sandbox: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-sandbox:latest\`\n`;
summary += `- Backend: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-server:latest\`\n`;
summary += `- Admin Portal: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-admin:latest\`\n`;
summary += `- Developer Portal: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/himarket-frontend:latest\`\n`;
summary += `- Sandbox: \`${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/sandbox:latest\`\n`;
} else {
summary += '⚠️ **Some image builds failed.** Please check the logs above.\n';
}
Expand Down
Loading