docs: add proper markdown header to ROADMAP.md#2
Closed
himanshu748 wants to merge 185 commits intomainfrom
Closed
Conversation
Update AnthropicProvider.complete to accept response_format and forward it to LiteLLMProvider. Added unit test in test_litellm_provider.py to verify parameter forwarding.
- Remove redundant register_web_search(mcp) call on line 54 - Keep single registration with credentials parameter - Tool implementation handles both credential sources internally - Added clarifying comment explaining the credential handling Fixes aden-hive#172
- Update .claude/skills/ structure in getting-started.md - Reflect actual skills generated by quickstart.sh: - agent-workflow/ - building-agents-construction/ - building-agents-core/ - building-agents-patterns/ - testing-agent/ Fixes aden-hive#177
Fixes aden-hive#202 - Update docs/getting-started.md to explain exports/ is created by users - Remove references to non-existent support_ticket_agent example - Update DEVELOPER.md with correct agent creation instructions
…file Add support for custom file encoding and size limits when viewing files. The max_size parameter prevents loading excessively large files by truncating content and adding a warning message when the limit is exceeded. Also includes validation for negative max_size values and checks if path is a file.
- Replace hardcoded /home/timothy/oss/hive/ with generic instruction - Add troubleshooting section for PEP 668 externally-managed-environment error - Document virtual environment setup for Python 3.12+ on macOS/WSL/Linux Fixes aden-hive#322 Fixes aden-hive#355
- Remove hardcoded max_retries_per_node = 3 - Use node_spec.max_retries for all retry logic - Add comprehensive test suite (6 test cases) - Allows per-node retry configuration as intended Fixes aden-hive#363
…detection Previously, the hallucination detection in SharedMemory.write() and OutputValidator.validate_no_hallucination() only checked the first 500 characters for code indicators. This allowed hallucinated code to bypass detection by prefixing with innocuous text. Changes: - Add _contains_code_indicators() method to SharedMemory and OutputValidator - Check entire string for strings under 10KB - Use strategic sampling (start, 25%, 50%, 75%, end) for longer strings - Expand code indicators to include JavaScript, SQL, and HTML/script patterns - Add comprehensive test suite with 19 test cases Fixes aden-hive#443 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…s-1769383167894 Add claude GitHub actions 1769383167894
Translate Korean
…directory-structure docs: update skills directory structure to match actual output
…r-response-format fix: align AnthropicProvider.complete with LLMProvider (response_format)
…-to-excluded feat: allow micro fixes be passed as a PR
…aden-hive#951) * config: add .gitattributes for cross-platform line ending consistency - Add comprehensive .gitattributes to normalize line endings - Ensure shell scripts always use LF (required for Unix execution) - Mark binary files explicitly to prevent corruption - Eliminate CRLF warnings for Windows contributors - Follow cross-platform best practices This fixes persistent 'LF will be replaced by CRLF' warnings that confuse Windows contributors during normal git operations. Fixes aden-hive#950 * fix: add trailing newline at end of file Per review feedback from @Hundao
micro-fix: fix ruff and excluding Docs
chore: fix lint issues
docs: chore for calling claude skills
…ation-error-handling Fix/json validation error handling
…r-check fix(list_dir): add isdir check before listing
…pose-references docs: remove outdated Docker Compose references
fixed ruff format --check
Fixes aden-hive#1582 Changed the first line from plain text 'Product Roadmap' to a proper markdown H1 header '# Product Roadmap' for consistency with other documentation files in the repository. Co-Authored-By: Himanshu Jha <jhahimanshu653@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedToo many files! This PR contains 187 files, which is 37 over the limit of 150. You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds a proper markdown H1 header to ROADMAP.md, changing line 1 from plain text "Product Roadmap" to markdown format "# Product Roadmap".
Changes:
- Added markdown H1 header formatting to ROADMAP.md
- Note: PR includes 184 upstream sync commits that should not be reviewed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi! I'm Himanshu Jha (@himanshu748). I'd like to work on this issue. Could you please assign it to me? This PR adds a proper markdown H1 header to ROADMAP.md, fixing issue aden-hive#1582. |
devin-ai-integration
bot
deleted the
devin/1769574187-docs-roadmap-header
branch
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
himanshu748
pushed a commit
that referenced
this pull request
Jan 31, 2026
Changes based on Copilot AI review (3 issues): 1. Increased thread join timeout (Issue #1): - Changed from 2 to 5 seconds - Made proportional to cleanup timeout - Defined as class constant _THREAD_JOIN_TIMEOUT 2. Handle asyncio.CancelledError explicitly (Issue #2): - Added separate except clause for CancelledError - Logs specific warning for cancelled cleanup - Re-raises CancelledError as per asyncio best practices - Added for both session and stdio_context cleanup 3. Increased cleanup timeout to match connection timeout (Issue #3): - Changed from 5 to 10 seconds (matches _connect_stdio timeout) - Defined as class constant _CLEANUP_TIMEOUT - Prevents incomplete cleanup with slow MCP servers
himanshu748
pushed a commit
that referenced
this pull request
Jan 31, 2026
Changes based on Copilot AI review (2 issues): 1. Thread join timeout was shorter than cleanup timeout (Issue #1): - Changed _THREAD_JOIN_TIMEOUT from 5 to 12 seconds - Must be >= cleanup timeout (10s) plus buffer for loop.stop() - Prevents thread abandonment during active cleanup 2. Added detailed comment for redundant None assignments (Issue #2): - Explained why we set _session/_stdio_context to None even if _cleanup_stdio_async() already did it - Documents the safety cases: timeout, failure, skip, cancellation - Makes code intent clear for future maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a proper markdown H1 header to
ROADMAP.md. The file previously started with plain text "Product Roadmap" instead of a proper markdown header "# Product Roadmap".ROADMAP.mdline 1. All other changes in the diff are from upstream sync and should NOT be reviewed as part of this PR.Recommendation: This PR should be closed and recreated with a branch based on
origin/mainto isolate only the intended change.Type of Change
Related Issues
Fixes aden-hive#1582
Changes Made (Intended)
ROADMAP.mdfromProduct Roadmapto# Product RoadmapTesting
Checklist
Human Review Checklist
ROADMAP.mdline 1 change (Product Roadmap→# Product Roadmap) is the intended changeorigin/mainLink to Devin run: https://app.devin.ai/sessions/626b4e606d97495f9640088656d06c35
Requested by: Himanshu Jha (@himanshu748)