WIP: Implement looker_project and more #15

lukas-at-harren · 2021-11-24T23:01:09Z

I added the following resources:

looker_project
looker_project_git_deploy_key
looker_project_git_repository

Those allow to setup Looker projects and git configuration.
In order for them to work properly, I had to fix the looker SDK (See also: looker-open-source/sdk-codegen#912).

Please only merge after:

Looker SDK has merged my fix upstream
This provider is updated to the latest SDK
The additions have been reviewed and tested by more people than me

––

Of course adding projects via Terraform is not without issues.
Besides the bug in the golang looker API client, there are some issues with the Looker API itself.

One is, that the API does not support deleting projects.
=> I solved this by issuing a warning to the user of the resource.

Another is, that the API client session must be forced into "dev"-mode in order to create projects.
=> That I am currently still testing.
=> One suggestion I have, if this turns out to be a major hassle, is to allow for a "workspace_id" configuration at the provider level. That way, the user could configure two looker providers, one per workspace_id (production, dev) and this problem would also be solved.

Adding a git-repository to a Looker project is a major hassle.
=> I attempt to solve this by having separate resources dealing with the git deploy key and the git repository configuration of a project. This way, a user of the resources can create a proper dependency graph creating a deploy key and assigning the deploy key to a Github project via the terraform github provider.

lukas-at-harren · 2021-11-24T23:02:37Z

pkg/looker/resource_connection.go

@@ -326,7 +326,7 @@ func expandWriteDBConnection(d *schema.ResourceData) (*apiclient.WriteDBConnecti

 	// optional values
 	if v, ok := d.GetOk("port"); ok {
-		port := int64(v.(int))


The latest version of the looker sdk has this field noted as string.

hirosassa · 2021-11-25T21:14:15Z

@lukas-at-harren Thank you for your contribution! I'll take a look tonight!

lukas-at-harren · 2022-02-01T10:50:58Z

I will check test failures this week.

hirosassa · 2022-03-08T22:15:15Z

@lukas-at-harren Hi, lukas! What's the status of this and related PR?

lukas-at-harren · 2022-03-09T08:05:49Z

@hirosassa hi, sorry for the massive delay in everything. But the people over at the Looker-SDK seem to have no time/attention for the PR I posted there. I bumped them in a comment, and hope to get things moving.

From my side, this is still active, and I hope that this contribution makes it through.
Unfortunate this is dependent on an implementation detail of the Looker SDK. I see no way around this, because the additions of my contribution require the SSH public key to be readable from the Looker API. Exactly that endpoint is broken with the current implementation of the Looker SDK (it simply assumes ALL responses are JSON... and therefore fails parsing them).

lukas-at-harren · 2022-03-17T07:14:49Z

@hirosassa there has been some movement upstream, my change/fix was not merged but there is now looker-open-source/sdk-codegen#1021 that should close this bug.

hirosassa · 2022-05-01T01:13:33Z

@lukas-at-harren Hi! Could you update this PR? sdk-codegen is updated!

…oject_git_repository

lukas-at-harren · 2022-06-13T13:49:44Z

@hirosassa hi, I finally got to rebase the PR onto your master. It seems to work fine (on our end).
I am just checking the lint.

hirosassa

Thanks for your contribution! I added a few comments. Please check!

hirosassa · 2022-06-13T20:35:32Z

pkg/looker/resource_project_git_deploy_key.go

+		}
+		return diag.FromErr(err)
+	}
+	d.Set("git_deploy_key", gitDeployKey)


should check err like below:

Suggested change

d.Set("git_deploy_key", gitDeployKey)

if err = d.Set("git_deploy_key", gitDeployKey); err != nil {

return diag.FromErr(err)

}

hirosassa · 2022-06-13T20:36:26Z

pkg/looker/resource_project_git_deploy_key.go

+	if err != nil {
+		return diag.FromErr(err)
+	}
+	d.Set("git_deploy_key", gitDeployKey)


Suggested change

d.Set("git_deploy_key", gitDeployKey)

if err = d.Set("git_deploy_key", gitDeployKey); err != nil {

return diag.FromErr(err)

}

hirosassa · 2022-06-13T20:37:08Z

pkg/looker/resource_project_git_repository.go

+	if err != nil {
+		return diag.FromErr(err)
+	}
+	d.Set("git_service_name", project.GitServiceName)


Suggested change

d.Set("git_service_name", project.GitServiceName)

if err = d.Set("git_service_name", project.GitServiceName); err != nil {

return diag.FromErr(err)

}

hirosassa · 2022-06-13T20:37:53Z

pkg/looker/resource_project_git_repository.go

+		return diag.FromErr(err)
+	}
+	d.Set("git_service_name", project.GitServiceName)
+	d.Set("git_remote_url", project.GitRemoteUrl)


Suggested change

d.Set("git_remote_url", project.GitRemoteUrl)

if err = d.Set("git_remote_url", project.GitRemoteUrl); err != nil {

return diag.FromErr(err)

}

hirosassa · 2022-06-13T20:41:58Z

pkg/looker/resource_project.go

+	writeProject := apiclient.WriteProject{
+		Name:            &projectName,
+	}
+	project, err := client.CreateProject(writeProject, nil)


Cloud you add [DEBUG] log before api call in Create, Read, Update, and Delete?

For example,
https://github.com/hirosassa/terraform-provider-looker/blob/master/pkg/looker/resource_user_attribute.go#L75

hirosassa · 2022-08-16T22:23:41Z

@lukas-at-harren Hi, what's the status?

Nabil-Lahssini · 2022-11-03T13:40:12Z

Hi guys, just to let you know that a new provider has been released with all the functionalities, project creation etc. It's open source. Feel free to use it and contribute
https://github.com/devoteamgcloud/terraform-provider-looker

vmichel95 · 2022-11-14T17:56:29Z

Hi guys, just to let you know that a new provider has been released with all the functionalities, project creation etc. It's open source. Feel free to use it and contribute https://github.com/devoteamgcloud/terraform-provider-looker

@Nabil-Lahssini can you add support for looker_permission_set resources

Nabil-Lahssini · 2022-11-24T14:17:26Z

@Nabil-Lahssini can you add support for looker_permission_set resources

@vmichel95 Hi, thank you for your response, support for looker_permission_set was just added today in version 0.2.0. Feel free to use it and give some feedback in the discussions section :) . You can also discuss other functionalities you want to see in future versions.

* upstream/master: Allow updating connection certificate (hirosassa#40) Fix hidden value domain whitelist (hirosassa#38) Update release.yml Update workflow (hirosassa#37) Fix user attribute user value delete (hirosassa#36) Support HiddenValueDomainWhitelist (hirosassa#35) Support IsDisabled (hirosassa#34)

lukas-at-harren commented Nov 24, 2021

View reviewed changes

lukas-at-harren mentioned this pull request Dec 6, 2021

fix: Fix ignorant json decoding looker-open-source/sdk-codegen#912

Closed

2 tasks

Implement looker_project, looker_project_git_deploy_key and looker_pr…

40fa566

…oject_git_repository

lukas-at-harren force-pushed the feat/looker-project branch from 82f2079 to 40fa566 Compare June 9, 2022 09:35

hirosassa requested changes Jun 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Implement looker_project and more #15

WIP: Implement looker_project and more #15

lukas-at-harren commented Nov 24, 2021 •

edited

Loading

lukas-at-harren Nov 24, 2021

hirosassa commented Nov 25, 2021

lukas-at-harren commented Feb 1, 2022

hirosassa commented Mar 8, 2022

lukas-at-harren commented Mar 9, 2022 •

edited

Loading

lukas-at-harren commented Mar 17, 2022

hirosassa commented May 1, 2022

lukas-at-harren commented Jun 13, 2022

hirosassa left a comment

hirosassa Jun 13, 2022

hirosassa Jun 13, 2022

hirosassa Jun 13, 2022

hirosassa Jun 13, 2022

hirosassa Jun 13, 2022

hirosassa commented Aug 16, 2022

Nabil-Lahssini commented Nov 3, 2022

vmichel95 commented Nov 14, 2022

Nabil-Lahssini commented Nov 24, 2022

WIP: Implement looker_project and more #15

Are you sure you want to change the base?

WIP: Implement looker_project and more #15

Conversation

lukas-at-harren commented Nov 24, 2021 • edited Loading

lukas-at-harren Nov 24, 2021

Choose a reason for hiding this comment

hirosassa commented Nov 25, 2021

lukas-at-harren commented Feb 1, 2022

hirosassa commented Mar 8, 2022

lukas-at-harren commented Mar 9, 2022 • edited Loading

lukas-at-harren commented Mar 17, 2022

hirosassa commented May 1, 2022

lukas-at-harren commented Jun 13, 2022

hirosassa left a comment

Choose a reason for hiding this comment

hirosassa Jun 13, 2022

Choose a reason for hiding this comment

hirosassa Jun 13, 2022

Choose a reason for hiding this comment

hirosassa Jun 13, 2022

Choose a reason for hiding this comment

hirosassa Jun 13, 2022

Choose a reason for hiding this comment

hirosassa Jun 13, 2022

Choose a reason for hiding this comment

hirosassa commented Aug 16, 2022

Nabil-Lahssini commented Nov 3, 2022

vmichel95 commented Nov 14, 2022

Nabil-Lahssini commented Nov 24, 2022

lukas-at-harren commented Nov 24, 2021 •

edited

Loading

lukas-at-harren commented Mar 9, 2022 •

edited

Loading