fix: adjust contract ABI writes to read from contract_interface key instead of contract_abi #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-5k0g1sr7b-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
zone117x
reviewed
May 13, 2025
| @@ -287,7 +287,7 @@ function parseDataStoreTxEventData( | |||
| block_height: blockData.block_height, | |||
| clarity_version: clarityVersion, | |||
| source_code: tx.parsed_tx.payload.code_body, | |||
| abi: JSON.stringify(tx.core_tx.contract_abi), | |||
| abi: JSON.stringify(tx.core_tx.contract_interface), | |||
There was a problem hiding this comment.
Should this be something like
abi: JSON.stringify(tx.core_tx.contract_interface ?? tx.core_tx.contract_abi)so that it works with tsvs containing the previous field name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks core changed the name of the key for this data from
contract_abitocontract_interfacein/new_blockevents. This PR reads from the new field.A replay or a manual backfill will be necessary to get all the missing ABIs from recently deployed contracts.