Skip to content

feat: store and expose vm_error for failed transactions #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: store and expose vm_error for failed transactions #2286

wants to merge 8 commits into from

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented May 16, 2025 •
edited
Loading

Fixes #2196

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2025 •
edited
Loading

Vercel deployment URL: https://stacks-blockchain-p2c85wbky-hirosystems.vercel.app 🚀

@codecov Codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/datastore/pg-write-store.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr changed the title feat: store and expose vm_error in failed transactions feat: store and expose vm_error for failed transactions May 16, 2025
@rafaelcr rafaelcr marked this pull request as ready for review May 16, 2025 18:22
@rafaelcr rafaelcr requested a review from zone117x May 16, 2025 22:45
zone117x
zone117x approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zone117x zone117x zone117x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose vm_error for failed contract-deploy txs
2 participants
@rafaelcr @zone117x