fix: migrate subdomains to wallet key address

[ahsan-javaid]

Description

Add command in cli to enable users to transfer subdomains to wallet-key addresses that correspond to all data-key addresses

Example: Running the command

stx migrate_subdomains "sound idle panel often situate develop unit text design antenna vendor screen opinion balcony share trigger accuse scatter visa uniform brass update opinion media"

For details refer to issue #1209

Type of Change

• New feature
• Bug fix
• API reference/documentation update
• Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Provide context on how tests should be performed.
cd packages/cli
npm run build
./bin.js migrate_subdomains "sound idle panel often situate develop unit text design antenna vendor screen opinion balcony share trigger accuse scatter visa uniform brass update opinion media"

Checklist

• Code is commented where needed
• Unit test coverage for new or modified code paths
• npm run test passes
• Changelog is updated
• Tag reviewers

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-js/HmqgQoY7Q6r5e4v1VWxR9n18kq2s
✅ Preview: https://stacks-js-git-fix-subdomain-migration-to-wall-2b3ed7-blockstack.vercel.app

[markmhendrickson]

@ahsan-javaid is this ready for testing? cc @pradel

[ahsan-javaid]

Update:

• Working on to write tests (In progress)
• @asimm241 is developing the api on subdomain-registrar side (In progress)

---

However mock testing can be done on this PR
Steps:

1. Clone stacks.js and setup
2. checkout to branch fix/subdomain-migration-to-wallet-addresses
3. cd packages/cli
4. Now run the command below
5. ./bin.js migrate_subdomains "sound idle panel often situate develop unit text design antenna vendor screen opinion balcony share trigger accuse scatter visa uniform brass update opinion media"

This will trigger the subdomain migration flow but actually subdomain will not be migrated as the actual migration url needs to be added.

---

I will provide the final update next week once its fully ready to test.

cc: @asimm241

[codecov-commenter]

Codecov Report

Merging #1226 (1ea90ee) into master (575b58d) will increase coverage by 0.27%.
The diff coverage is 93.87%.

❗ Current head 1ea90ee differs from pull request most recent head 63c4083. Consider uploading reports for the commit 63c4083 to get more accurate results

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
+ Coverage   64.78%   65.06%   +0.27%     
==========================================
  Files         126      126              
  Lines        8753     8834      +81     
  Branches     1882     1895      +13     
==========================================
+ Hits         5671     5748      +77     
- Misses       2956     2960       +4     
  Partials      126      126              

Impacted Files	Coverage Δ
packages/cli/src/argparse.ts	15.16% <ø> (ø)
packages/cli/src/cli.ts	22.94% <93.67%> (+5.40%)	⬆️
packages/cli/src/utils.ts	33.24% <94.44%> (+3.06%)	⬆️
packages/transactions/src/utils.ts	94.49% <100.00%> (+0.05%)	⬆️

[markmhendrickson]

@ahsan-javaid Is this ready to test by chance? And mind providing a link to the API work on the registrar?

[asimm241]

@ahsan-javaid Is this ready to test by chance? And mind providing a link to the API work on the registrar?

@markmhx It will be ready by the end of this week.

[asimm241]

@ahsan-javaid Is this ready to test by chance? And mind providing a link to the API work on the registrar?

I'll open up a PR today or tomorrow for the API registrar section.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
stacks-js	✅ Ready (Inspect)	Visit Preview	Jul 19, 2022 at 5:56PM (UTC)
stacksjs	✅ Ready (Inspect)	Visit Preview	Jul 19, 2022 at 5:56PM (UTC)

[markmhendrickson]

@ahsan-javaid @asimm241 Any updates on this work? I've heard from @pradel that his users are now waiting eagerly for this functionality 🙏

[asimm241]

@markmhx This PR is ready, the corresponding PR in the registrar will probably be created today OR tomorrow. Then It can be tested. The unite tests will be added later. :)

[asimm241]

Corresponding PR in registrar stacks-archive/subdomain-registrar#88

[pradel]

@janniks this function will allow legacy users to migrate their usernames to the Hiro wallet.

But what about transferring subdomains for Hiro wallet users, should stacks.js export a function that does this?

[unclemantis]

Would like to see a detailed markdown of exactly the issue being solved. I am a little confused. 👍

[janniks]

@janniks this function will allow legacy users to migrate their usernames to the Hiro wallet.

But what about transferring subdomains for Hiro wallet users, should stacks.js export a function that does this?

That's a good point. I think they should be separate command though. For example, I would keep migrate_subdomain as the "fix" of legacy ids and add another command transfer_subdomain for the ability to send the subdomain to whoever (by address).
Thoughts?

[janniks]

Would like to see a detailed markdown of exactly the issue being solved. I am a little confused. 👍

👍 I can add some more detail to the command descriptions. In short, the old Blockstack connect username where owned by a different derivation path of (data private key) of wallets, rather than the wallet key, which the web wallet uses now to own usernames. This command will migrate the address from the old to the current.

[pradel]

That's a good point. I think they should be separate command though. For example, I would keep migrate_subdomain as the "fix" of legacy ids and add another command transfer_subdomain for the ability to send the subdomain to whoever (by address).
Thoughts?

Seems like a good approach 👍

[pradel]

@janniks created a separate issue for this #1323

[pradel]

@janniks wondering what is missing for this one (and the subdomain pr) to go live, our users are eagerly waiting 🤓

[saralab]

@zone117x : We are awaiting your review, can you take a peek please?

[zone117x]

The code and tests look good. But I haven't tested this out myself. If the folks testing this change are happy then LGTM.

[janniks]

✅ Ran final tests, we're just waiting for stacks-archive/subdomain-registrar#88 to be merged (I don't have access), then we can merge this PR.

[janniks]

📦 Released under 4.3.4