closes #109: fixing install.xml
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the XMLDB schemas for the main onlinejudge_tasks table and the assignment feedback plugin, bumping both versions to 20250711 and streamlining field and key definitions by removing legacy ordering attributes.
- Bumps
VERSIONto 20250711 in both install.xml files. - Simplifies
<FIELD>and<KEY>entries by droppingPREVIOUS,NEXT, and explicitUNSIGNEDattributes. - Moves comments inline and removes redundant
LENGTHattributes where type defaults apply.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| db/install.xml | Updated schema version; removed legacy ordering attributes and inlined comments. |
| clients/mod/assign/feedback/onlinejudge/db/install.xml | Synced version bump and streamlined field/key definitions in the feedback plugin. |
Comments suppressed due to low confidence (1)
clients/mod/assign/feedback/onlinejudge/db/install.xml:15
- [nitpick] Grammar in the COMMENT could be improved for clarity, for example: 'Percentage of grade awarded for a presentation error.'
<FIELD NAME="ratiope" TYPE="number" LENGTH="20" NOTNULL="true" DEFAULT="0.0" SEQUENCE="false" DECIMALS="10" COMMENT="How much grade can earn when get a presentation error."/>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.