improve the metadata to satisfy the need of HMA#165
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Hi @sjh120 , At present, we can find that some unit tests still report errors (checks -> python package / build ). Here are my suggestions:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 80.09% 79.25% -0.84%
==========================================
Files 69 69
Lines 3305 3370 +65
==========================================
+ Hits 2647 2671 +24
- Misses 658 699 +41 ☔ View full report in Codecov by Sentry. |
| def _get_primary_and_alternate_keys(self): | ||
| """Get set of primary and alternate keys. | ||
|
|
||
| Returns: | ||
| set: | ||
| Set of keys. | ||
| """ | ||
| keys = set(self.alternate_keys) | ||
| if self.primary_key: | ||
| keys.update({self.primary_key}) | ||
|
|
||
| return keys |
There was a problem hiding this comment.
Have you ever test this function? Not sure whether primary_key is a dict..If so, we may need to chang the name
|
I notice that How do you think here? |
Sure, only use I' will change the code, there are still some flaws in this PR. |
Co-authored-by: Zhongsheng Ji <9573586@qq.com>
|
@jalr4ever I'm not sure, it may have something to do with the new model that is planned to be developed. |
Description
Motivation and Context
How has this been tested?
Types of changes
Checklist: